Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Etcd memory leak when using jetcd-core 0.7.6 #1240

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Etcd memory leak when using jetcd-core 0.7.6 #1240

merged 1 commit into from
Oct 16, 2023

Conversation

lburgazzoli
Copy link
Collaborator

@lburgazzoli lburgazzoli commented Oct 10, 2023 •
edited

Fixes #1236

@lburgazzoli lburgazzoli changed the title Etcd memory leak when using jetcd-core 0.7.6 #1236 Etcd memory leak when using jetcd-core 0.7.6 Oct 10, 2023
@lburgazzoli lburgazzoli mentioned this pull request Oct 10, 2023
Closed
liangyuanpeng
liangyuanpeng reviewed Oct 11, 2023
View reviewed changes
Copy link
Contributor

@liangyuanpeng liangyuanpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have test it and it can fix #1236

@lburgazzoli lburgazzoli marked this pull request as ready for review October 11, 2023 07:42
liangyuanpeng
liangyuanpeng reviewed Oct 11, 2023
View reviewed changes
jetcd-core/src/test/java/io/etcd/jetcd/impl/LeaseMemoryLeakTest.java Outdated
int after = extractGoRoutinesCount(uri);
assertThat(after).isGreaterThan(0);

assertThat(after).isGreaterThan(before);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this makes this a flake test as there will be some fluctuations here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking into that

@lburgazzoli lburgazzoli force-pushed the gh-1236 branch 16 times, most recently from 1978abd to df3aa33 Compare October 11, 2023 13:58
@lburgazzoli
Etcd memory leak when using jetcd-core 0.7.6 etcd-io#1236
5c689fe 
Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com>
@lburgazzoli lburgazzoli merged commit 26762fa into etcd-io:main Oct 16, 2023
9 checks passed
@lburgazzoli lburgazzoli deleted the gh-1236 branch October 16, 2023 08:16
@liangyuanpeng liangyuanpeng mentioned this pull request Jan 14, 2024
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liangyuanpeng liangyuanpeng liangyuanpeng left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Etcd memory leak when using jetcd-core 0.7.6
2 participants
@lburgazzoli @liangyuanpeng