[fix][test] Fix flaky test LeaderElectionTest.revalidateLeaderWithinSameSession #22383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanmz
reviewed
Apr 1, 2024
pulsar-metadata/src/test/java/org/apache/pulsar/metadata/BaseMetadataStoreTest.java
Outdated
Show resolved
Hide resolved
|
@lhotari could you please review the pr |
lhotari
approved these changes
Sep 23, 2024
BewareMyPower
approved these changes
Sep 23, 2024
|
This PR is 544 commits behind the master. Could you merge the master branch? |
@BewareMyPower I'll close and reopen this PR to trigger a new PR build. In Pulsar CI, the PR build will always merge the master branch before running the PR build. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22383 +/- ##
============================================
+ Coverage 73.57% 74.52% +0.95%
- Complexity 32624 34428 +1804
============================================
Files 1877 1934 +57
Lines 139502 144980 +5478
Branches 15299 15838 +539
============================================
+ Hits 102638 108049 +5411
+ Misses 28908 28646 -262
- Partials 7956 8285 +329
Flags with carried forward coverage won't be shown. Click here to find out more. |
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 26, 2024
…ameSession (apache#22383) (cherry picked from commit 216b830) (cherry picked from commit e63dcd4)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 26, 2024
…ameSession (apache#22383) (cherry picked from commit 216b830) (cherry picked from commit e63dcd4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21535
Motivation
The test should Provide Consistent Answer .Test revalidateLeaderWithinSameSession failed too many times.
Modifications
We are calling the method once store the object and check both the conditions . In this way at both conditions we are checking the same Object.
Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: