Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][test] Fix flaky test LeaderElectionTest.revalidateLeaderWithinSameSession #22383

Merged
merged 3 commits into from
Sep 23, 2024
Merged

[fix][test] Fix flaky test LeaderElectionTest.revalidateLeaderWithinSameSession #22383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c6d037
Update MetadataCache.java
nikam14 Mar 14, 2024
c697b7e
Update BaseMetadataStoreTest.java
nikam14 Mar 15, 2024
d45a1bc
changed local variable name
nikam14 Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pulsar-metadata/src/main/java/org/apache/pulsar/metadata/api/MetadataCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public interface MetadataCache<T> {
*
* @param path
* the path of the object in the metadata store
* @return the cached object or an empty {@link Optional} is the cache doesn't have the object
* @return the cached object or an empty {@link Optional} is the cache does not have the object
*/
Optional<T> getIfCached(String path);

Expand Down
5 changes: 3 additions & 2 deletions pulsar-metadata/src/test/java/org/apache/pulsar/metadata/BaseMetadataStoreTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,10 +145,11 @@ public static void assertEqualsAndRetry(Supplier<Object> actual,
int retryCount,
long intSleepTimeInMillis) throws Exception {
assertTrue(retryStrategically((__) -> {
if (actual.get().equals(expectedAndRetry)) {
Object actualObject = actual.get();
if (actualObject.equals(expectedAndRetry)) {
return false;
}
assertEquals(actual.get(), expected);
assertEquals(actualObject, expected);
return true;
}, retryCount, intSleepTimeInMillis));
}
Expand Down
Loading