[fix][cli] Fix the shell script parameter passthrough syntax #22867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- parameters with whitespaces won't be properly passed through to the actual command unless "$@" is used (instead of $@ without double quotes. - fixes shellcheck warning https://github.com/koalaman/shellcheck/wiki/SC2068
RobertIndie
approved these changes
Jun 7, 2024
lhotari
added a commit
that referenced
this pull request
Jun 7, 2024
(cherry picked from commit c81c0f6)
lhotari
added a commit
that referenced
this pull request
Jun 10, 2024
(cherry picked from commit c81c0f6)
lhotari
added a commit
that referenced
this pull request
Jun 10, 2024
(cherry picked from commit c81c0f6)
15 tasks
coderzc
added a commit
to coderzc/pulsar
that referenced
this pull request
Jun 17, 2024
…pache#22867)" This reverts commit c81c0f6.
15 tasks
coderzc
added a commit
that referenced
this pull request
Jun 17, 2024
lhotari
added a commit
to lhotari/pulsar
that referenced
this pull request
Jun 17, 2024
…hrough syntax (apache#22867)" (apache#22921)" This reverts commit fa74538.
4 tasks
lhotari
added a commit
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
$@with"$@"inbin/pulsarandbin/bookkeeperDocumentation
docdoc-requireddoc-not-neededdoc-complete