-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Revert "[fix][cli] Fix the shell script parameter passthrough syntax (#22867)" #22921
Conversation
…pache#22867)" This reverts commit c81c0f6.
@coderzc Please add the following content to your PR description and select a checkbox:
|
@coderzc @RobertIndie @merlimat I don't agree with reverting this change. The syntax of |
There are several problems with
|
The |
…hrough syntax (apache#22867)" (apache#22921)" This reverts commit fa74538.
@coderzc Please review #22923. Reverting the shell script was not the correct solution to address this problem. I've explained in #22923 and also comments above. I'd like to finally fix the shell script syntax for Pulsar 4.0.0 so that it's not forever invalid. There's no need to cherry-pick to older versions if that's a concern. |
This reverts commit c81c0f6.
Fixes #xyz
Main Issue: #xyz
PIP: #xyz
Motivation
#22867 introduced some break changes, such as
bin/pulsar zookeeper-shell --run-one "ls /ledgers"
can't work after introduced 22867.Modifications
Revert #22867
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: