Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Revert "[fix][cli] Fix the shell script parameter passthrough syntax (#22867)" #22921

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

coderzc
Copy link
Member

@coderzc coderzc commented Jun 17, 2024

This reverts commit c81c0f6.

Fixes #xyz

Main Issue: #xyz

PIP: #xyz

Motivation

#22867 introduced some break changes, such as bin/pulsar zookeeper-shell --run-one "ls /ledgers" can't work after introduced 22867.

Modifications

Revert #22867

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

Copy link

@coderzc Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Jun 17, 2024
@coderzc coderzc closed this Jun 17, 2024
@coderzc coderzc reopened this Jun 17, 2024
@merlimat merlimat changed the title Revert "[fix][cli] Fix the shell script parameter passthrough syntax (#22867)" [fix] Revert "[fix][cli] Fix the shell script parameter passthrough syntax (#22867)" Jun 17, 2024
@coderzc coderzc merged commit fa74538 into apache:master Jun 17, 2024
69 of 80 checks passed
coderzc added a commit that referenced this pull request Jun 17, 2024
coderzc added a commit that referenced this pull request Jun 17, 2024
coderzc added a commit that referenced this pull request Jun 17, 2024
@lhotari
Copy link
Member

lhotari commented Jun 17, 2024

#22867 introduced some break changes, such as bin/pulsar zookeeper-shell --run-one "ls /ledgers" can't work after introduced 22867.

@coderzc @RobertIndie @merlimat I don't agree with reverting this change. The syntax of bin/pulsar zookeeper-shell --run-one "ls /ledgers" is simply wrong. It just happened to work before when the shell script didn't correctly handle parameters.

@lhotari
Copy link
Member

lhotari commented Jun 17, 2024

There are several problems with bin/pulsar zookeeper-shell --run-one "ls /ledgers"

  1. zookeeper-shell has never supported an option called --run-one
  2. The parameter for zookeeper-shell shouldn't be quoted.

@lhotari
Copy link
Member

lhotari commented Jun 17, 2024

The --run-once "ls /path" syntax is supported for the Python based zk-shell, https://pypi.org/project/zk-shell/ . That's not used when pulsar zookeeper-shell is called.

lhotari added a commit to lhotari/pulsar that referenced this pull request Jun 17, 2024
@lhotari
Copy link
Member

lhotari commented Oct 9, 2024

@coderzc Please review #22923. Reverting the shell script was not the correct solution to address this problem. I've explained in #22923 and also comments above. I'd like to finally fix the shell script syntax for Pulsar 4.0.0 so that it's not forever invalid. There's no need to cherry-pick to older versions if that's a concern.

@lhotari lhotari added this to the 4.0.0 milestone Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants