Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Connector-V2] [Doc] Add TableSourceFactory and TableSinkFactory Doc #3343

Merged
merged 4 commits into from
Nov 11, 2022

Conversation

Hisoka-X
Copy link
Member

@Hisoka-X Hisoka-X commented Nov 9, 2022

Purpose of this pull request

Check list

Co-authored-by: Zongwen Li <zongwen.li.tech@gmail.com>
@Hisoka-X Hisoka-X requested a review from ashulin November 10, 2022 08:52
TaoZex
TaoZex previously approved these changes Nov 10, 2022
Copy link
Contributor

@TaoZex TaoZex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

seatunnel-connectors-v2/README.md Outdated Show resolved Hide resolved
seatunnel-connectors-v2/README.zh.md Outdated Show resolved Hide resolved
Co-authored-by: Eric <gaojun2048@gmail.com>
Copy link
Member

@TyrantLucifer TyrantLucifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@TyrantLucifer TyrantLucifer merged commit eee84f7 into apache:dev Nov 11, 2022
@Hisoka-X Hisoka-X deleted the doc_for_factory branch November 13, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants