[Improve] mongodb connector v2 add source query capability #3697
Conversation
|
Please check ci error |
|
please fix ci error |
Thanks for your review,I have made the changes. |
| @@ -66,6 +71,7 @@ mongodb { | |||
| uri = "mongodb://username:password@127.0.0.1:27017/mypost?retryWrites=true&writeConcern=majority" | |||
| database = "mydatabase" | |||
| collection = "mycollection" | |||
| matchQuery = "{"id":3}" | |||
There was a problem hiding this comment.
I'm not sure the json in hocon value can be parse normally, maybe you should change a way, like use object
matchQuery = {
"id"=3
}
There was a problem hiding this comment.
This place is a string, except that this string has to conform to a certain format in order to be transformed into a BsonDocument
There was a problem hiding this comment.
The core is this method：
.find(Optional.ofNullable(params.getMatchQuery()).isPresent() ? BsonDocument.parse(params.getMatchQuery()) : new BsonDocument())
I have tested in my development env example mode, it is ok
There was a problem hiding this comment.
The core is this method： .find(Optional.ofNullable(params.getMatchQuery()).isPresent() ? BsonDocument.parse(params.getMatchQuery()) : new BsonDocument()) I have tested in my development env example mode, it is ok
Because I consider one thing is: the query statement is best to conform to the native syntax of mongodb, this will be very friendly to the developer, he does not need to learn anything extra, directly paste the history of mongodb query statement can be used
There was a problem hiding this comment.
Ok for me, please update e2e test case. Thanks.
There was a problem hiding this comment.
Thanks for your review,I have made the changes.
|
cc @TyrantLucifer PTAL, thanks. |
|
@MonsterChenzhuo Hi, #3607 Looks like you didn't finish. Do you want to keep doing this? |
* [Improve] mongodb connector v2 add source query capability
* [Improve] mongodb connector v2 add source query capability
Purpose of this pull request
close #3567,#3607
I was going to finish refactoring the mongodb linker in this pr, but considering the number of changes to refactoring, I split it up. #3698
Check list
New License Guide