[Improve][Connector-v2][Jdbc] Refactor AbstractJdbcCatalog

[whhe]

Purpose of this pull request

Extract the common logic of MySqlCatalog and SqlServerCatalog to AbstractJdbcCatalog.

Check list

• Code changed are covered with tests, or it does not need tests for reason:
• If any new Jar binary package adding in your PR, please add License Notice according
  New License Guide
• If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
• If you are contributing the connector code, please check that the following files are updated:
  1. Update change log that in connector document. For more details you can refer to connector-v2
  2. Update plugin-mapping.properties and add new connector information in it
  3. Update the pom file of seatunnel-dist
• Update the release-note.

[TyrantLucifer]

Please add unit test cases.

[whhe]

Please add unit test cases.

Seems SeaTunnel does not depend on Mockito now, I want to introduce it to mock jdbc connection, is it OK ? And if so what version should I choose?

[liugddx]

Mockito

Refer to seatunnel-e2e/connector-jdbc-e2e

[whhe]

Mockito

Refer to seatunnel-e2e/connector-jdbc-e2e

So I should add IT cases in module connector-jdbc-e2e instead of UT cases in the modified module, am I right?

[EricJoy2048]

Mockito

Refer to seatunnel-e2e/connector-jdbc-e2e

So I should add IT cases in module connector-jdbc-e2e instead of UT cases in the modified module, am I right?

Yes, you can add IT for this pr.

[ic4y]

@whhe Great commit! Now we just need to resolve the conflicts.

[whhe]

I rebased the code and seems it's coverd by the IT cases for now. @ic4y @EricJoy2048 @liugddx

[ic4y]

@XiaoJiang521 PTAL

[whhe]

The failed case JdbcPhoenixIT seems not related to this pr.

[whhe]

@XiaoJiang521 Comments addressed, what do you think for now.

[XiaoJiang521]

LGTM

[whhe]

@ic4y @EricJoy2048 PTAL

[ic4y]

At present, no tests cover these modifications, and the UT tests are also not working. We should add a seatunnel-catalog-e2e module under the seatunnel-e2e module and use testcontainers to cover these tests.

[whhe]

At present, no tests cover these modifications, and the UT tests are also not working. We should add a seatunnel-catalog-e2e module under the seatunnel-e2e module and use testcontainers to cover these tests.

Finally got caught with this work again ... will try it later.

[whhe]

I add testCatalog method in AbstractJdbcIT and enable it for MySql, Oracle and SqlServer in this pr, looks like these IT cases finally passed.

As PG does not use the same base IT class, I want to modify it in another pr, what do you think? @ic4y

[whhe]

Thanks to help from @EricJoy2048, CI jobs are totally green now.

[whhe]

All catalog implementations related to AbstractJdbcCatalog are covered by IT cases now, and UT failure is not related.

PTAL @ic4y @liugddx @EricJoy2048

[liugddx]

All catalog implementations related to AbstractJdbcCatalog are covered by IT cases now, and UT failure is not related.

PTAL @ic4y @liugddx @EricJoy2048

Waiting for #5403 to be merged

[whhe]

@liugddx Could you please help to retry the failed ut case? Seems the testJobLevelCheckpointTimeOut is not completely fixed.

[liugddx]

@liugddx Could you please help to retry the failed ut case? Seems the testJobLevelCheckpointTimeOut is not completely fixed.

Yes, I found the problem, it's not very stable. I will fix this problem in other PR #5414

[whhe]

All tests passed, PTAL @ic4y @liugddx @EricJoy2048

[ic4y]

@XiaoJiang521 is familiar with this area, could you please review it?

[XiaoJiang521]

LGTM @ic4y