minor clean up

apache · Nov 18, 2024 · 12704ea · 12704ea
1 parent 4589687
commit 12704ea
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/solr/modules/llm/src/java/org/apache/solr/llm/store/rest/ManagedEmbeddingModelStore.java b/solr/modules/llm/src/java/org/apache/solr/llm/store/rest/ManagedEmbeddingModelStore.java
@@ -107,8 +107,7 @@ public void loadStoredModels() {
 
   private void addModelFromMap(Map<String, Object> modelMap) {
     try {
-      final SolrEmbeddingModel embedder = fromEmbeddingModelMap(modelMap);
-      addModel(embedder);
+      addModel(fromEmbeddingModelMap(modelMap));
     } catch (final EmbeddingModelException e) {
       throw new SolrException(SolrException.ErrorCode.BAD_REQUEST, e);
     }
@@ -186,12 +185,10 @@ private static List<Object> modelsAsManagedResources(List<SolrEmbeddingModel> mo
 
   @SuppressWarnings("unchecked")
   public static SolrEmbeddingModel fromEmbeddingModelMap(Map<String, Object> embeddingModel) {
-    final SolrEmbeddingModel embedder =
-        SolrEmbeddingModel.getInstance(
+        return SolrEmbeddingModel.getInstance(
             (String) embeddingModel.get(CLASS_KEY), // modelClassName
             (String) embeddingModel.get(NAME_KEY), // modelName
             (Map<String, Object>) embeddingModel.get(PARAMS_KEY));
-    return embedder;
   }
 
   private static LinkedHashMap<String, Object> toEmbeddingModelMap(SolrEmbeddingModel model) {