Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-17490: Check for existence of perl executable and skip if it doesnt exist #2753

Merged
merged 3 commits into from
Nov 16, 2024
Merged

SOLR-17490: Check for existence of perl executable and skip if it doesnt exist #2753

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e3ac0ca
Check for existence of perl executable and skip if it doesnt exist
epugh Oct 10, 2024
3dabcc0
Update gradle/documentation/changes-to-html.gradle
epugh Nov 12, 2024
2afe52d
Rework the checks to be more robust
epugh Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion gradle/documentation/changes-to-html.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,16 @@ class ChangesToHtmlTask extends DefaultTask {

def toHtml(File versionsFile) {
def output = new ByteArrayOutputStream()

// Check if the perl executable exists
def perlExecutable = project.externalTool("perl")
if (!new File(perlExecutable).exists()) {
epugh marked this conversation as resolved.
Show resolved Hide resolved
logger.warn("WARNING: Perl is not installed or could not be found at: ${perlExecutable}, skipping creating Changes.html")
return
}

def result = project.exec {
executable project.externalTool("perl")
perlExecutable
standardInput changesFile.newInputStream()
standardOutput project.file("${targetDir.get().getAsFile()}/Changes.html").newOutputStream()
errorOutput = output
Expand Down
Loading