Skip to content

Commit

Permalink
[SPARK-48433][BUILD] Upgrade checkstyle to 10.17.0
Browse files Browse the repository at this point in the history
### What changes were proposed in this pull request?
The pr aims to
- upgrade `checkstyle` from `10.15.0` to `10.17.0`.
- clean some outdated comments.

### Why are the changes needed?
https://github.com/checkstyle/checkstyle/releases/tag/checkstyle-10.17.0
https://github.com/checkstyle/checkstyle/releases/tag/checkstyle-10.16.0

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
- Manually test:
```
sh dev/lint-java
```
- Pass GA.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes #46763 from panbingkun/SPARK-48433.

Authored-by: panbingkun <panbingkun@baidu.com>
Signed-off-by: yangjie01 <yangjie01@baidu.com>
  • Loading branch information
panbingkun authored and LuciferYang committed Jun 3, 2024
1 parent 8d534c0 commit 9270931
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3480,7 +3480,7 @@
-->
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
<version>10.15.0</version>
<version>10.17.0</version>
</dependency>
</dependencies>
<executions>
Expand Down
3 changes: 1 addition & 2 deletions project/plugins.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,9 @@

addSbtPlugin("software.purpledragon" % "sbt-checkstyle-plugin" % "4.0.1")

// sbt-checkstyle-plugin uses an old version of checkstyle. Match it to Maven's.
// If you are changing the dependency setting for checkstyle plugin,
// please check pom.xml in the root of the source tree too.
libraryDependencies += "com.puppycrawl.tools" % "checkstyle" % "10.15.0"
libraryDependencies += "com.puppycrawl.tools" % "checkstyle" % "10.17.0"

// checkstyle uses guava 33.1.0-jre.
libraryDependencies += "com.google.guava" % "guava" % "33.1.0-jre"
Expand Down

0 comments on commit 9270931

Please sign in to comment.