Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-48433][BUILD] Upgrade checkstyle to 10.17.0 #46763

Closed
wants to merge 1 commit into from

Conversation

panbingkun
Copy link
Contributor

@panbingkun panbingkun commented May 27, 2024

What changes were proposed in this pull request?

The pr aims to

  • upgrade checkstyle from 10.15.0 to 10.17.0.
  • clean some outdated comments.

Why are the changes needed?

https://github.com/checkstyle/checkstyle/releases/tag/checkstyle-10.17.0
https://github.com/checkstyle/checkstyle/releases/tag/checkstyle-10.16.0

Does this PR introduce any user-facing change?

No.

How was this patch tested?

  • Manually test:
sh dev/lint-java
  • Pass GA.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the BUILD label May 27, 2024
@panbingkun panbingkun marked this pull request as ready for review May 28, 2024 10:46
@LuciferYang
Copy link
Contributor

Merged into master for Spark 4.0. Thanks @panbingkun

riyaverm-db pushed a commit to riyaverm-db/spark that referenced this pull request Jun 7, 2024
### What changes were proposed in this pull request?
The pr aims to
- upgrade `checkstyle` from `10.15.0` to `10.17.0`.
- clean some outdated comments.

### Why are the changes needed?
https://github.com/checkstyle/checkstyle/releases/tag/checkstyle-10.17.0
https://github.com/checkstyle/checkstyle/releases/tag/checkstyle-10.16.0

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
- Manually test:
```
sh dev/lint-java
```
- Pass GA.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes apache#46763 from panbingkun/SPARK-48433.

Authored-by: panbingkun <panbingkun@baidu.com>
Signed-off-by: yangjie01 <yangjie01@baidu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants