Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-4839][YARN] Adding a documentation about dynamic resource allocation. #3689

Closed
wants to merge 2 commits into from

Conversation

oza
Copy link
Contributor

@oza oza commented Dec 13, 2014

Signed-off-by: Tsuyoshi Ozawa ozawa.tsuyoshi@gmail.com

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@oza oza changed the title [SPARK-4839] Adding a documentation about dynamic resource allocation. [SPARK-4839][YARN] Adding a documentation about dynamic resource allocation. Dec 14, 2014
<td><code>spark.dynamicAllocation.enabled</code></td>
<td>false</td>
<td>
Enabling dynamic resource allocation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add more explanation of what dynamic resource allocation is here? As a user unfamiliar with the feature, this description doesn't tell me enough to know whether I want to turn it on.

@JoshRosen
Copy link
Contributor

/cc @aarondav @andrewor14

@oza
Copy link
Contributor Author

oza commented Dec 16, 2014

Thanks for your comment, I'm updating it.

Signed-off-by: Tsuyoshi Ozawa <ozawa.tsuyoshi@gmail.com>
Signed-off-by: Tsuyoshi Ozawa <ozawa.tsuyoshi@gmail.com>
@oza
Copy link
Contributor Author

oza commented Dec 16, 2014

Updated a description of dynamic resource allocation based on a comment by @ash211.

@andrewor14
Copy link
Contributor

Hey @oza thanks for doing this. I actually intend to structure this a little differently in its own separate page and there is another JIRA (SPARK-4140) that I filed earlier for this. I'll take this up and work on it in the next day or two. In the mean time would you mind closing this PR?

@oza
Copy link
Contributor Author

oza commented Dec 17, 2014

@andrewor14 OK, feel free to use this PR. Closing this as duplicated one.

@oza oza closed this Dec 17, 2014
asfgit pushed a commit that referenced this pull request Dec 20, 2014
Once the external shuffle service is also documented, the dynamic allocation section will link to it. Let me know if the whole dynamic allocation should be moved to its separate page; I personally think the organization might be cleaner that way.

This patch builds on top of oza's work in #3689.

aarondav pwendell

Author: Andrew Or <andrew@databricks.com>
Author: Tsuyoshi Ozawa <ozawa.tsuyoshi@gmail.com>

Closes #3731 from andrewor14/document-dynamic-allocation and squashes the following commits:

1281447 [Andrew Or] Address a few comments
b9843f2 [Andrew Or] Document the configs as well
246fb44 [Andrew Or] Merge branch 'SPARK-4839' of github.com:oza/spark into document-dynamic-allocation
8c64004 [Andrew Or] Add documentation for dynamic allocation (without configs)
6827b56 [Tsuyoshi Ozawa] Fixing a documentation of spark.dynamicAllocation.enabled.
53cff58 [Tsuyoshi Ozawa] Adding a documentation about dynamic resource allocation.

(cherry picked from commit 15c03e1)
Signed-off-by: Andrew Or <andrew@databricks.com>
asfgit pushed a commit that referenced this pull request Dec 20, 2014
Once the external shuffle service is also documented, the dynamic allocation section will link to it. Let me know if the whole dynamic allocation should be moved to its separate page; I personally think the organization might be cleaner that way.

This patch builds on top of oza's work in #3689.

aarondav pwendell

Author: Andrew Or <andrew@databricks.com>
Author: Tsuyoshi Ozawa <ozawa.tsuyoshi@gmail.com>

Closes #3731 from andrewor14/document-dynamic-allocation and squashes the following commits:

1281447 [Andrew Or] Address a few comments
b9843f2 [Andrew Or] Document the configs as well
246fb44 [Andrew Or] Merge branch 'SPARK-4839' of github.com:oza/spark into document-dynamic-allocation
8c64004 [Andrew Or] Add documentation for dynamic allocation (without configs)
6827b56 [Tsuyoshi Ozawa] Fixing a documentation of spark.dynamicAllocation.enabled.
53cff58 [Tsuyoshi Ozawa] Adding a documentation about dynamic resource allocation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants