Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-4140] Document dynamic allocation #3731

Closed

Conversation

andrewor14
Copy link
Contributor

Once the external shuffle service is also documented, the dynamic allocation section will link to it. Let me know if the whole dynamic allocation should be moved to its separate page; I personally think the organization might be cleaner that way.

This patch builds on top of @oza's work in #3689.

@aarondav @pwendell

@SparkQA
Copy link

SparkQA commented Dec 18, 2014

Test build #24575 has started for PR 3731 at commit b9843f2.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 18, 2014

Test build #24575 has finished for PR 3731 at commit b9843f2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24575/
Test PASSed.

configurations are described on the [configurations page](configuration.html#dynamic-allocation)
and in the subsequent sections in detail.

Additionally, your application must use an external shuffle service (described below). To enable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add a short clause explaining why this is the case

@sryza
Copy link
Contributor

sryza commented Dec 18, 2014

Super nice to have documentation at this level of detail. This mostly looks good, I left a few comments.

@SparkQA
Copy link

SparkQA commented Dec 20, 2014

Test build #24663 has started for PR 3731 at commit 1281447.

  • This patch merges cleanly.

@andrewor14
Copy link
Contributor Author

Ok I'm merging this into master and 1.2 thanks guys

asfgit pushed a commit that referenced this pull request Dec 20, 2014
Once the external shuffle service is also documented, the dynamic allocation section will link to it. Let me know if the whole dynamic allocation should be moved to its separate page; I personally think the organization might be cleaner that way.

This patch builds on top of oza's work in #3689.

aarondav pwendell

Author: Andrew Or <andrew@databricks.com>
Author: Tsuyoshi Ozawa <ozawa.tsuyoshi@gmail.com>

Closes #3731 from andrewor14/document-dynamic-allocation and squashes the following commits:

1281447 [Andrew Or] Address a few comments
b9843f2 [Andrew Or] Document the configs as well
246fb44 [Andrew Or] Merge branch 'SPARK-4839' of github.com:oza/spark into document-dynamic-allocation
8c64004 [Andrew Or] Add documentation for dynamic allocation (without configs)
6827b56 [Tsuyoshi Ozawa] Fixing a documentation of spark.dynamicAllocation.enabled.
53cff58 [Tsuyoshi Ozawa] Adding a documentation about dynamic resource allocation.

(cherry picked from commit 15c03e1)
Signed-off-by: Andrew Or <andrew@databricks.com>
@asfgit asfgit closed this in 15c03e1 Dec 20, 2014
@andrewor14 andrewor14 deleted the document-dynamic-allocation branch December 20, 2014 03:38
@SparkQA
Copy link

SparkQA commented Dec 20, 2014

Test build #24663 has finished for PR 3731 at commit 1281447.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24663/
Test PASSed.

@oza
Copy link
Contributor

oza commented Dec 20, 2014

@andrewor14 good job, thanks!

@JoshRosen
Copy link
Contributor

@pwendell @andrewor14 Can we publish updated docs to the website? It looks like these changes aren't live yet: https://spark.apache.org/docs/latest/job-scheduling.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants