Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-41499][BUILD] Upgrade Protobuf version to 3.21.11 #39042

Closed
wants to merge 1 commit into from

Conversation

gengliangwang
Copy link
Member

What changes were proposed in this pull request?

Upgrade Protobuf version to 3.21.11

Why are the changes needed?

There are some bug fixes in the latest release https://github.com/protocolbuffers/protobuf/releases:

Does this PR introduce any user-facing change?

No

How was this patch tested?

GA tests

@gengliangwang
Copy link
Member Author

Actually I got this error when running SBT locally

[error] file:/Users/gengliang.wang/.m2/repository/com/google/protobuf/protoc/3.21.9/protoc-3.21.9-osx-x86_64.exe: not found: /Users/gengliang.wang/.m2/repository/com/google/protobuf/protoc/3.21.9/protoc-3.21.9-osx-x86_64.exe

Upgrading it to 3.21.11 works.
The two java fixes in the new release also look good.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@gengliangwang
Copy link
Member Author

@HyukjinKwon @dongjoon-hyun Thanks for the review.
Merging to master

beliefer pushed a commit to beliefer/spark that referenced this pull request Dec 18, 2022
### What changes were proposed in this pull request?

Upgrade Protobuf version to 3.21.11

### Why are the changes needed?

There are some bug fixes in the latest release https://github.com/protocolbuffers/protobuf/releases:
* Use bit-field int values in buildPartial to skip work on unset groups of fields. (protocolbuffers/protobuf#10960)
* Mark nested builder as clean after clear is called (protocolbuffers/protobuf#10984)

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

GA tests

Closes apache#39042 from gengliangwang/upgradeProtobuf.

Authored-by: Gengliang Wang <gengliang@apache.org>
Signed-off-by: Gengliang Wang <gengliang@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants