Mark nested builder as clean after clear is called #10984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omitting this step was leading to stale cached versions of nested messages. See #10624
shaod2
approved these changes
Nov 14, 2022
Merged
gengliangwang
added a commit
to apache/spark
that referenced
this pull request
Dec 13, 2022
### What changes were proposed in this pull request? Upgrade Protobuf version to 3.21.11 ### Why are the changes needed? There are some bug fixes in the latest release https://github.com/protocolbuffers/protobuf/releases: * Use bit-field int values in buildPartial to skip work on unset groups of fields. (protocolbuffers/protobuf#10960) * Mark nested builder as clean after clear is called (protocolbuffers/protobuf#10984) ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? GA tests Closes #39042 from gengliangwang/upgradeProtobuf. Authored-by: Gengliang Wang <gengliang@apache.org> Signed-off-by: Gengliang Wang <gengliang@apache.org>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
### What changes were proposed in this pull request? Upgrade Protobuf version to 3.21.11 ### Why are the changes needed? There are some bug fixes in the latest release https://github.com/protocolbuffers/protobuf/releases: * Use bit-field int values in buildPartial to skip work on unset groups of fields. (protocolbuffers/protobuf#10960) * Mark nested builder as clean after clear is called (protocolbuffers/protobuf#10984) ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? GA tests Closes apache#39042 from gengliangwang/upgradeProtobuf. Authored-by: Gengliang Wang <gengliang@apache.org> Signed-off-by: Gengliang Wang <gengliang@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omitting this step was leading to stale cached versions of nested messages. See #10624