[SPARK-43920][SQL][CONNECT] Create sql/api module #41426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvanhovell
reviewed
Jun 1, 2023
| <sbt.project.name>sql-api</sbt.project.name> | ||
| </properties> | ||
|
|
||
| <dependencies> |
There was a problem hiding this comment.
Should we add common/util as a dependency?
There was a problem hiding this comment.
I will add it once we move code into this module.
LuciferYang
requested changes
Jun 2, 2023
|
@LuciferYang right. I updated the SparkBuild to exclude it. |
LuciferYang
approved these changes
Jun 2, 2023
|
Waiting CI |
|
Merging. |
There was a problem hiding this comment.
BTW, sorry for asking this question after merging.
- What is the minimal target for migration in order to help
connectmodule? According to the PR description,Rowis also mentioned. So,sql/catalyst/src/main/scala/org/apache/spark/sql/typesis not enough? - Does it cause many MIMA exceptions against old
catalystmodule?
In current scope, Row, coders, data types are required. However we may discover more during the process. |
|
Got it. Let's see it in the actual PR~ |
czxm
pushed a commit
to czxm/spark
that referenced
this pull request
Jun 12, 2023
### What changes were proposed in this pull request? We need a sql/api module to host public API like DataType, Row, etc. This module can be shared between Catalyst and Spark Connect client so that client do not need to depend on Catalyst anymore. ### Why are the changes needed? Towards Spark Connect client do not need to depend on Catalyst anymore. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? N/A Closes apache#41426 from amaliujia/add_sql_api. Authored-by: Rui Wang <rui.wang@databricks.com> Signed-off-by: Herman van Hovell <herman@databricks.com>
HyukjinKwon
pushed a commit
that referenced
this pull request
Jul 25, 2024
### What changes were proposed in this pull request? The pr aims to update doc `sql/README.md`. ### Why are the changes needed? After #41426, We have added a subproject `API` to our `SQL moudle`, so we need to update the doc `sql/README.md` synchronously. ### Does this PR introduce _any_ user-facing change? Yes, make the doc clearer and more accurate. ### How was this patch tested? Manually test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #47476 from panbingkun/minor_docs. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
ilicmarkodb
pushed a commit
to ilicmarkodb/spark
that referenced
this pull request
Jul 29, 2024
### What changes were proposed in this pull request? The pr aims to update doc `sql/README.md`. ### Why are the changes needed? After apache#41426, We have added a subproject `API` to our `SQL moudle`, so we need to update the doc `sql/README.md` synchronously. ### Does this PR introduce _any_ user-facing change? Yes, make the doc clearer and more accurate. ### How was this patch tested? Manually test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47476 from panbingkun/minor_docs. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
fusheng-rd
pushed a commit
to fusheng-rd/spark
that referenced
this pull request
Aug 6, 2024
### What changes were proposed in this pull request? The pr aims to update doc `sql/README.md`. ### Why are the changes needed? After apache#41426, We have added a subproject `API` to our `SQL moudle`, so we need to update the doc `sql/README.md` synchronously. ### Does this PR introduce _any_ user-facing change? Yes, make the doc clearer and more accurate. ### How was this patch tested? Manually test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47476 from panbingkun/minor_docs. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
### What changes were proposed in this pull request? The pr aims to update doc `sql/README.md`. ### Why are the changes needed? After apache#41426, We have added a subproject `API` to our `SQL moudle`, so we need to update the doc `sql/README.md` synchronously. ### Does this PR introduce _any_ user-facing change? Yes, make the doc clearer and more accurate. ### How was this patch tested? Manually test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47476 from panbingkun/minor_docs. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We need a sql/api module to host public API like DataType, Row, etc. This module can be shared between Catalyst and Spark Connect client so that client do not need to depend on Catalyst anymore.
Why are the changes needed?
Towards Spark Connect client do not need to depend on Catalyst anymore.
Does this PR introduce any user-facing change?
No
How was this patch tested?
N/A