Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR][DOCS] Update doc sql/README.md #47476

Closed
wants to merge 1 commit into from

Conversation

panbingkun
Copy link
Contributor

@panbingkun panbingkun commented Jul 25, 2024

What changes were proposed in this pull request?

The pr aims to update doc sql/README.md.

Why are the changes needed?

After #41426, We have added a subproject API to our SQL moudle, so we need to update the doc sql/README.md synchronously.

Does this PR introduce any user-facing change?

Yes, make the doc clearer and more accurate.

How was this patch tested?

Manually test.

Was this patch authored or co-authored using generative AI tooling?

No.

@@ -99,7 +99,7 @@ SHOW VIEWS FROM default LIKE 'sam*';
| default | sam1 | false |
+-----------+------------+--------------+

-- List all views from the current database matching the pattern `sam|sujtemp*`
-- List all views from the current database matching the pattern `sam|suj|temp*`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR, but I would like to take this opportunity to bring up this correction. (Full angle to half angle)

@panbingkun panbingkun marked this pull request as ready for review July 25, 2024 01:58
@panbingkun
Copy link
Contributor Author

cc @amaliujia @HyukjinKwon

@HyukjinKwon
Copy link
Member

Merged to master.

@@ -3,7 +3,8 @@ Spark SQL

This module provides support for executing relational queries expressed in either SQL or the DataFrame/Dataset API.

Spark SQL is broken up into four subprojects:
Spark SQL is broken up into five subprojects:
- API (sql/api) - Includes some public API like DataType, Row, etc. This component can be shared between Catalyst and Spark Connect client.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the documentation!

Copy link
Contributor

@amaliujia amaliujia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late LGTM

ilicmarkodb pushed a commit to ilicmarkodb/spark that referenced this pull request Jul 29, 2024
### What changes were proposed in this pull request?
The pr aims to update doc `sql/README.md`.

### Why are the changes needed?
After apache#41426, We have added a subproject `API` to our `SQL moudle`, so we need to update the doc `sql/README.md` synchronously.

### Does this PR introduce _any_ user-facing change?
Yes, make the doc clearer and more accurate.

### How was this patch tested?
Manually test.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes apache#47476 from panbingkun/minor_docs.

Authored-by: panbingkun <panbingkun@baidu.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
fusheng-rd pushed a commit to fusheng-rd/spark that referenced this pull request Aug 6, 2024
### What changes were proposed in this pull request?
The pr aims to update doc `sql/README.md`.

### Why are the changes needed?
After apache#41426, We have added a subproject `API` to our `SQL moudle`, so we need to update the doc `sql/README.md` synchronously.

### Does this PR introduce _any_ user-facing change?
Yes, make the doc clearer and more accurate.

### How was this patch tested?
Manually test.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes apache#47476 from panbingkun/minor_docs.

Authored-by: panbingkun <panbingkun@baidu.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
attilapiros pushed a commit to attilapiros/spark that referenced this pull request Oct 4, 2024
### What changes were proposed in this pull request?
The pr aims to update doc `sql/README.md`.

### Why are the changes needed?
After apache#41426, We have added a subproject `API` to our `SQL moudle`, so we need to update the doc `sql/README.md` synchronously.

### Does this PR introduce _any_ user-facing change?
Yes, make the doc clearer and more accurate.

### How was this patch tested?
Manually test.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes apache#47476 from panbingkun/minor_docs.

Authored-by: panbingkun <panbingkun@baidu.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants