[SPARK-44268][CORE][TEST] Add tests to ensure error-classes.json and docs are in sync #41813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
approved these changes
Jul 2, 2023
|
+1, LGTM. Merging to master. |
|
Thanks @MaxGekk |
|
@Hisoka-X How to sync the error classes to doc ? manual ? |
At now, yes. Developer only need change doc which had change in |
This was referenced Jul 3, 2023
HyukjinKwon
pushed a commit
that referenced
this pull request
Jul 3, 2023
…E_ARGUMENTS` error into doc ### What changes were proposed in this pull request? This is a followup PR for #41750, because we add test for sync doc and `error-classes.json` after #41813 . We should add `TABLE_VALUED_FUNCTION_TOO_MANY_TABLE_ARGUMENTS` (add on #41750) into doc. ### Why are the changes needed? sync error and doc ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? exist test. Closes #41827 from Hisoka-X/SPARK-44200_follow_up_error_json_doc. Authored-by: Jia Fan <fanjiaeminem@qq.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
HyukjinKwon
added a commit
that referenced
this pull request
Jul 6, 2023
… doc ### What changes were proposed in this pull request? This is a followup PR for #41623, because we add test for sync doc and `error-classes.json` after #41813 . We should add `INVALID_BITMAP_POSITION` (add on #41623) into doc. ### Why are the changes needed? CI fails without this PR. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing test. Closes #41870 from HyukjinKwon/SPARK-44154. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
HyukjinKwon
pushed a commit
that referenced
this pull request
Jul 7, 2023
…onditions` doc automatic ### What changes were proposed in this pull request? This is a follow up PR for #41813, change test to automatic generate `sql-error-conditions` doc. Like other GOLDEN_FILES test, if the doc not match will report a error during test. ### Why are the changes needed? 1. make sure the `error-classes.json` sync with doc 2. and developer sync doc easier. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? add new test. Closes #41865 from Hisoka-X/SPARK-44268_error_json_follow_up. Authored-by: Jia Fan <fanjiaeminem@qq.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
… doc ### What changes were proposed in this pull request? This is a followup PR for apache#41623, because we add test for sync doc and `error-classes.json` after apache#41813 . We should add `INVALID_BITMAP_POSITION` (add on apache#41623) into doc. ### Why are the changes needed? CI fails without this PR. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing test. Closes apache#41870 from HyukjinKwon/SPARK-44154. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
…onditions` doc automatic ### What changes were proposed in this pull request? This is a follow up PR for apache#41813, change test to automatic generate `sql-error-conditions` doc. Like other GOLDEN_FILES test, if the doc not match will report a error during test. ### Why are the changes needed? 1. make sure the `error-classes.json` sync with doc 2. and developer sync doc easier. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? add new test. Closes apache#41865 from Hisoka-X/SPARK-44268_error_json_follow_up. Authored-by: Jia Fan <fanjiaeminem@qq.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add new test to make sure to
error-classes.jsonare match with series ofsql-error-conditions.md.After this PR, any difference between
error-classes.jsonand document with report a error during test.Note: only compare error class name at now.
Also fix all different which be found by new test case.
Why are the changes needed?
Make sure our error-classes.json always sync with doc.
Does this PR introduce any user-facing change?
No
How was this patch tested?
new test.