[SPARK-44268][CORE][TEST][FOLLOWUP] Add test to generate sql-error-conditions doc automatic
#41865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
reviewed
Jul 5, 2023
docs/sql-error-conditions-incomplete-type-definition-error-class.md
Outdated
Show resolved
Hide resolved
docs/sql-error-conditions-invalid-parameter-value-error-class.md
Outdated
Show resolved
Hide resolved
Hisoka-X
commented
Jul 6, 2023
| s"Error class: $errorClass does not contain sub class: $s in error-classes.json") | ||
| s | ||
| def quoteParameter(content: String): String = { | ||
| "(?<!MAP|STRUCT|ARRAY)<(.*?)>".r.replaceAllIn(content, (m: Regex.Match) => { |
There was a problem hiding this comment.
@MaxGekk I updated the rule, fix all problems you metioned. Please check the rule is ok or not. Thanks.
Hisoka-X
commented
Jul 6, 2023
| @@ -55,7 +55,7 @@ Thousands separators (, or G) may not appear after the decimal point in the numb | |||
|
|
|||
| ## UNEXPECTED_TOKEN | |||
|
|
|||
| Found the unexpected `<token>` in the format string; the structure of the format string must match: `[MI|S]` `[$]` `[0|9|G|,]*` `[.|D]` `[0|9]*` `[$]` `[PR|MI|S]`. | |||
| Found the unexpected `<token>` in the format string; the structure of the format string must match: [MI|S] [$] [0|9|G|,]* [.|D] [0|9]* [$] [PR|MI|S]. | |||
There was a problem hiding this comment.
This one a little special, can I add "`" quote in error-classes.json to make sure [MI|S] has `[MI|S]`?
Hisoka-X
force-pushed
the
SPARK-44268_error_json_follow_up
branch
from
4568225
to
f1b13d4
Compare
MaxGekk
approved these changes
Jul 6, 2023
Hisoka-X
force-pushed
the
SPARK-44268_error_json_follow_up
branch
from
3371770
to
fe4204e
Compare
HyukjinKwon
approved these changes
Jul 7, 2023
|
Merged to master. |
|
Thanks @HyukjinKwon @MaxGekk @beliefer |
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
…onditions` doc automatic ### What changes were proposed in this pull request? This is a follow up PR for apache#41813, change test to automatic generate `sql-error-conditions` doc. Like other GOLDEN_FILES test, if the doc not match will report a error during test. ### Why are the changes needed? 1. make sure the `error-classes.json` sync with doc 2. and developer sync doc easier. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? add new test. Closes apache#41865 from Hisoka-X/SPARK-44268_error_json_follow_up. Authored-by: Jia Fan <fanjiaeminem@qq.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow up PR for #41813, change test to automatic generate
sql-error-conditionsdoc. Like other GOLDEN_FILES test, if the doc not match will report a error during test.Why are the changes needed?
error-classes.jsonsync with docDoes this PR introduce any user-facing change?
No
How was this patch tested?
add new test.