[SPARK-44834][PYTHON][SQL][TESTS] Add SQL query tests for Python UDTFs #42517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueshin
approved these changes
Aug 16, 2023
dtenedor
approved these changes
Aug 17, 2023
ueshin
changed the title
|
Thanks! merging to master/3.5. |
ueshin
pushed a commit
that referenced
this pull request
Aug 17, 2023
### What changes were proposed in this pull request? This PR adds a new sql query test suite for running Python UDTFs in SQL. You can trigger the test using ``` SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly *SQLQueryTestSuite -- -z udtf/udtf.sql" ``` ### Why are the changes needed? To add more test cases for Python UDTFs. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added new golden file tests. Closes #42517 from allisonwang-db/spark-44834-udtf-sql-test. Authored-by: allisonwang-db <allison.wang@databricks.com> Signed-off-by: Takuya UESHIN <ueshin@databricks.com> (cherry picked from commit be04ac1) Signed-off-by: Takuya UESHIN <ueshin@databricks.com>
wangyum
pushed a commit
that referenced
this pull request
Aug 18, 2023
…lts of the udtf tests ### What changes were proposed in this pull request? This is a follow up for #42517. We need to re-generate the analyzer results for udtf tests after #42519 is merged. Also updated PythonUDTFSuite after #42520 is merged. ### Why are the changes needed? To fix test failures ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Test only change Closes #42543 from allisonwang-db/spark-44834-fix. Authored-by: allisonwang-db <allison.wang@databricks.com> Signed-off-by: Yuming Wang <yumwang@ebay.com>
wangyum
pushed a commit
that referenced
this pull request
Aug 18, 2023
…lts of the udtf tests ### What changes were proposed in this pull request? This is a follow up for #42517. We need to re-generate the analyzer results for udtf tests after #42519 is merged. Also updated PythonUDTFSuite after #42520 is merged. ### Why are the changes needed? To fix test failures ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Test only change Closes #42543 from allisonwang-db/spark-44834-fix. Authored-by: allisonwang-db <allison.wang@databricks.com> Signed-off-by: Yuming Wang <yumwang@ebay.com> (cherry picked from commit bb41cd8) Signed-off-by: Yuming Wang <yumwang@ebay.com>
valentinp17
pushed a commit
to valentinp17/spark
that referenced
this pull request
Aug 24, 2023
### What changes were proposed in this pull request? This PR adds a new sql query test suite for running Python UDTFs in SQL. You can trigger the test using ``` SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly *SQLQueryTestSuite -- -z udtf/udtf.sql" ``` ### Why are the changes needed? To add more test cases for Python UDTFs. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added new golden file tests. Closes apache#42517 from allisonwang-db/spark-44834-udtf-sql-test. Authored-by: allisonwang-db <allison.wang@databricks.com> Signed-off-by: Takuya UESHIN <ueshin@databricks.com>
valentinp17
pushed a commit
to valentinp17/spark
that referenced
this pull request
Aug 24, 2023
…lts of the udtf tests ### What changes were proposed in this pull request? This is a follow up for apache#42517. We need to re-generate the analyzer results for udtf tests after apache#42519 is merged. Also updated PythonUDTFSuite after apache#42520 is merged. ### Why are the changes needed? To fix test failures ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Test only change Closes apache#42543 from allisonwang-db/spark-44834-fix. Authored-by: allisonwang-db <allison.wang@databricks.com> Signed-off-by: Yuming Wang <yumwang@ebay.com>
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
### What changes were proposed in this pull request? This PR adds a new sql query test suite for running Python UDTFs in SQL. You can trigger the test using ``` SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly *SQLQueryTestSuite -- -z udtf/udtf.sql" ``` ### Why are the changes needed? To add more test cases for Python UDTFs. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added new golden file tests. Closes apache#42517 from allisonwang-db/spark-44834-udtf-sql-test. Authored-by: allisonwang-db <allison.wang@databricks.com> Signed-off-by: Takuya UESHIN <ueshin@databricks.com>
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
…lts of the udtf tests ### What changes were proposed in this pull request? This is a follow up for apache#42517. We need to re-generate the analyzer results for udtf tests after apache#42519 is merged. Also updated PythonUDTFSuite after apache#42520 is merged. ### Why are the changes needed? To fix test failures ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Test only change Closes apache#42543 from allisonwang-db/spark-44834-fix. Authored-by: allisonwang-db <allison.wang@databricks.com> Signed-off-by: Yuming Wang <yumwang@ebay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds a new sql query test suite for running Python UDTFs in SQL. You can trigger the test using
Why are the changes needed?
To add more test cases for Python UDTFs.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added new golden file tests.