[SPARK-45075][SQL] Fix alter table with invalid default value will not report error #42810
+39
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hisoka-X
commented
Sep 5, 2023
Comment on lines
+371
to
+379
| checkError( | ||
| exception = intercept[AnalysisException] { | ||
| sql("alter table t add column s bigint default badvalue") | ||
| }, | ||
| errorClass = "INVALID_DEFAULT_VALUE.UNRESOLVED_EXPRESSION", | ||
| parameters = Map( | ||
| "statement" -> "ALTER TABLE", | ||
| "colName" -> "`s`", | ||
| "defaultValue" -> "badvalue")) |
There was a problem hiding this comment.
This test case will report error normally before this PR, but we don't have any test case to prove it.
Comment on lines
+382
to
+390
| checkError( | ||
| exception = intercept[AnalysisException] { | ||
| sql("alter table t alter column s set default badvalue") | ||
| }, | ||
| errorClass = "INVALID_DEFAULT_VALUE.UNRESOLVED_EXPRESSION", | ||
| parameters = Map( | ||
| "statement" -> "ALTER TABLE ALTER COLUMN", | ||
| "colName" -> "`s`", | ||
| "defaultValue" -> "badvalue")) |
There was a problem hiding this comment.
Add this test case to prove the new change worked. But the more negative case in sql/core/src/test/scala/org/apache/spark/sql/sources/InsertSuite.scala and only worked for V1, after this PR merged, I will move it to sql/core/src/test/scala/org/apache/spark/sql/SQLInsertTestSuite.scala in #42802
cloud-fan
reviewed
Sep 5, 2023
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Util.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Sep 5, 2023
...talyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2AlterTableCommands.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Sep 5, 2023
...talyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2AlterTableCommands.scala
Show resolved
Hide resolved
dtenedor
approved these changes
Sep 5, 2023
...talyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2AlterTableCommands.scala
Outdated
Show resolved
Hide resolved
...talyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2AlterTableCommands.scala
Show resolved
Hide resolved
cloud-fan
approved these changes
Sep 6, 2023
dongjoon-hyun
approved these changes
Sep 8, 2023
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 8, 2023
…t report error ### What changes were proposed in this pull request? This PR make sure ALTER TABLE ALTER COLUMN with invalid default value on DataSource V2 will report error, before this PR it will alter sucess. ### Why are the changes needed? Fix the error behavior on DataSource V2 with ALTER TABLE statement. ### Does this PR introduce _any_ user-facing change? Yes, the invalid default value will report error. ### How was this patch tested? Add new test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #42810 from Hisoka-X/SPARK-45075_alter_invalid_default_value_on_v2. Authored-by: Jia Fan <fanjiaeminem@qq.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit 4dd4737) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 8, 2023
…t report error ### What changes were proposed in this pull request? This PR make sure ALTER TABLE ALTER COLUMN with invalid default value on DataSource V2 will report error, before this PR it will alter sucess. ### Why are the changes needed? Fix the error behavior on DataSource V2 with ALTER TABLE statement. ### Does this PR introduce _any_ user-facing change? Yes, the invalid default value will report error. ### How was this patch tested? Add new test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #42810 from Hisoka-X/SPARK-45075_alter_invalid_default_value_on_v2. Authored-by: Jia Fan <fanjiaeminem@qq.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit 4dd4737) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
|
Merged to master/3.5/3.4. |
|
Thanks @cloud-fan @dongjoon-hyun @dtenedor |
|
Oh, I realized that branch-3.4 fails. It seems that there is a behavior difference in branch-3.4. Let me revert this from branch-3.4. Could you make a backporting PR to branch-3.4, @Hisoka-X ? |
|
This is reverted via e3b8402 from branch-3.4 for now. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 12, 2023
…ll not report error ### What changes were proposed in this pull request? This is a backporting PR to branch-3.4 from #42810 Changed the way of assert the error to adapt to 3.4 ### Why are the changes needed? Fix bug on 3.4 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? add new test. ### Was this patch authored or co-authored using generative AI tooling? No Closes #42876 from Hisoka-X/SPARK-45075_followup_3.4_alter_column. Authored-by: Jia Fan <fanjiaeminem@qq.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
viirya
pushed a commit
to viirya/spark-1
that referenced
this pull request
Oct 19, 2023
…t report error ### What changes were proposed in this pull request? This PR make sure ALTER TABLE ALTER COLUMN with invalid default value on DataSource V2 will report error, before this PR it will alter sucess. ### Why are the changes needed? Fix the error behavior on DataSource V2 with ALTER TABLE statement. ### Does this PR introduce _any_ user-facing change? Yes, the invalid default value will report error. ### How was this patch tested? Add new test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#42810 from Hisoka-X/SPARK-45075_alter_invalid_default_value_on_v2. Authored-by: Jia Fan <fanjiaeminem@qq.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit 4dd4737) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
viirya
pushed a commit
to viirya/spark-1
that referenced
this pull request
Oct 19, 2023
…ll not report error ### What changes were proposed in this pull request? This is a backporting PR to branch-3.4 from apache#42810 Changed the way of assert the error to adapt to 3.4 ### Why are the changes needed? Fix bug on 3.4 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? add new test. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#42876 from Hisoka-X/SPARK-45075_followup_3.4_alter_column. Authored-by: Jia Fan <fanjiaeminem@qq.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR make sure ALTER TABLE ALTER COLUMN with invalid default value on DataSource V2 will report error, before this PR it will alter sucess.
Why are the changes needed?
Fix the error behavior on DataSource V2 with ALTER TABLE statement.
Does this PR introduce any user-facing change?
Yes, the invalid default value will report error.
How was this patch tested?
Add new test.
Was this patch authored or co-authored using generative AI tooling?
No.