[SPARK-46938][BUILD] Remove javax-servlet-api exclusion rule for SBT
#45194
Conversation
There was a problem hiding this comment.
Oh, this PR is unable to pass CI, @HiuKwok ? I guess this PR should pass CIs and the previous PR will cause failure without this. Did I understand correctly?
this will cause test failure,
It will only cause failure when Jetty upgrades to 11 AND the exclusion rule is present. |
|
@dongjoon-hyun Your understanding is correct 👍 |
|
Could you revise the PR description? You don't need to mention any failure here. It only causes confusions. |
|
Done. |
dongjoon-hyun
changed the title
dongjoon-hyun
changed the title
javax-servlet-api exclusion rule for SBT
| @@ -1075,7 +1075,6 @@ object ExcludedDependencies { | |||
| // purpose only. Here we exclude them from the whole project scope and add them w/ yarn only. | |||
| excludeDependencies ++= Seq( | |||
| ExclusionRule(organization = "com.sun.jersey"), | |||
| ExclusionRule("javax.servlet", "javax.servlet-api"), | |||
There was a problem hiding this comment.
this is intended, to avoid conflict with jakarta.servlet-api:4.x, the tricky thing is that jakarta.servlet-api:4.x actually contains javax.servlet classes
There was a problem hiding this comment.
Ya, this is a spin-off from the following original PR. We know that this is a transient status, @pan3793 . Do you have any other concern?
There was a problem hiding this comment.
I get the point. The change makes sense to me.
What changes were proposed in this pull request?
javax-servlet-apipackage.Why are the changes needed?
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI build
Was this patch authored or co-authored using generative AI tooling?
No