Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-46938][BUILD] Remove javax-servlet-api exclusion rule for SBT #45194

Closed
wants to merge 2 commits into from
Closed

[SPARK-46938][BUILD] Remove javax-servlet-api exclusion rule for SBT #45194

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8204c6
Remove javax exclusion rule
HiuKwok Feb 21, 2024
7b14160
Update rules
HiuKwok Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion project/SparkBuild.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1075,7 +1075,6 @@ object ExcludedDependencies {
// purpose only. Here we exclude them from the whole project scope and add them w/ yarn only.
excludeDependencies ++= Seq(
ExclusionRule(organization = "com.sun.jersey"),
ExclusionRule("javax.servlet", "javax.servlet-api"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is intended, to avoid conflict with jakarta.servlet-api:4.x, the tricky thing is that jakarta.servlet-api:4.x actually contains javax.servlet classes

Copy link
Member

@dongjoon-hyun dongjoon-hyun Feb 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, this is a spin-off from the following original PR. We know that this is a transient status, @pan3793 . Do you have any other concern?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the point. The change makes sense to me.

ExclusionRule("javax.ws.rs", "jsr311-api"))
)
}
Expand Down