[SPARK-47309][SQL][XML] Add schema inference unit tests #45411
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shujingyang-db
changed the title
HyukjinKwon
pushed a commit
that referenced
this pull request
Mar 8, 2024
### What changes were proposed in this pull request? This PR fixes XML schema inference issues: 1. when there's an empty tag 2. when merging schema for NullType ### Why are the changes needed? Fix a bug ### Does this PR introduce _any_ user-facing change? Yes ### How was this patch tested? Unit tests. There's a follow-up [PR](#45411) that introduces comprehensive tests for schema inference. ### Was this patch authored or co-authored using generative AI tooling? No Closes #45426 from shujingyang-db/fix-xml-schema-inference. Authored-by: Shujing Yang <shujing.yang@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
sandip-db
approved these changes
Mar 9, 2024
...core/src/test/scala/org/apache/spark/sql/execution/datasources/xml/XmlInferSchemaSuite.scala
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/xml/TestXmlData.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/xml/TestXmlData.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/xml/TestXmlData.scala
Outdated
Show resolved
Hide resolved
HyukjinKwon
approved these changes
Mar 11, 2024
|
Merged to master. |
sweisdb
pushed a commit
to sweisdb/spark
that referenced
this pull request
Apr 1, 2024
### What changes were proposed in this pull request? This PR fixes XML schema inference issues: 1. when there's an empty tag 2. when merging schema for NullType ### Why are the changes needed? Fix a bug ### Does this PR introduce _any_ user-facing change? Yes ### How was this patch tested? Unit tests. There's a follow-up [PR](apache#45411) that introduces comprehensive tests for schema inference. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#45426 from shujingyang-db/fix-xml-schema-inference. Authored-by: Shujing Yang <shujing.yang@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
sweisdb
pushed a commit
to sweisdb/spark
that referenced
this pull request
Apr 1, 2024
### What changes were proposed in this pull request? As titled. ### Why are the changes needed? Fix a bug. ### Does this PR introduce _any_ user-facing change? Yes ### How was this patch tested? Unit tests ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#45411 from shujingyang-db/xml-inference-check. Authored-by: Shujing Yang <shujing.yang@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As titled.
Why are the changes needed?
Fix a bug.
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
Unit tests
Was this patch authored or co-authored using generative AI tooling?
No