Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-47309][SQL][XML] Fix schema inference issues in XML #45426

Closed

Conversation

shujingyang-db
Copy link
Contributor

@shujingyang-db shujingyang-db commented Mar 7, 2024

What changes were proposed in this pull request?

This PR fixes XML schema inference issues:

  1. when there's an empty tag

  2. when merging schema for NullType

Why are the changes needed?

Fix a bug

Does this PR introduce any user-facing change?

Yes

How was this patch tested?

Unit tests. There's a follow-up PR that introduces comprehensive tests for schema inference.

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the SQL label Mar 7, 2024
@HyukjinKwon
Copy link
Member

Merged to master.

HyukjinKwon added a commit that referenced this pull request Mar 8, 2024
### What changes were proposed in this pull request?

This PR changes the y/n message and condition consistent within merging script.

### Why are the changes needed?

For consistency.

```
Would you like to use the modified body? (y/N): y
...
Proceed with merging pull request #45426? (y/N): y
...
Merge complete (local ref PR_TOOL_MERGE_PR_45426_MASTER). Push to apache? (y/N): y
...
Would you like to pick 9cac2bb into another branch? (y/N): n
...
Would you like to update an associated JIRA? (y/N): y
...
Check if the JIRA information is as expected (Y/n): y  # <-- Inconsistent.
```

### Does this PR introduce _any_ user-facing change?

No, dev-only.

### How was this patch tested?

Manually tested.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #45427 from HyukjinKwon/minor-script.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
sweisdb pushed a commit to sweisdb/spark that referenced this pull request Apr 1, 2024
### What changes were proposed in this pull request?

This PR fixes XML schema inference issues:

1. when there's an empty tag

2. when merging schema for NullType

### Why are the changes needed?

Fix a bug

### Does this PR introduce _any_ user-facing change?

Yes

### How was this patch tested?

Unit tests. There's a follow-up [PR](apache#45411) that introduces comprehensive tests for schema inference.

### Was this patch authored or co-authored using generative AI tooling?

No

Closes apache#45426 from shujingyang-db/fix-xml-schema-inference.

Authored-by: Shujing Yang <shujing.yang@databricks.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
sweisdb pushed a commit to sweisdb/spark that referenced this pull request Apr 1, 2024
### What changes were proposed in this pull request?

This PR changes the y/n message and condition consistent within merging script.

### Why are the changes needed?

For consistency.

```
Would you like to use the modified body? (y/N): y
...
Proceed with merging pull request apache#45426? (y/N): y
...
Merge complete (local ref PR_TOOL_MERGE_PR_45426_MASTER). Push to apache? (y/N): y
...
Would you like to pick 9cac2bb into another branch? (y/N): n
...
Would you like to update an associated JIRA? (y/N): y
...
Check if the JIRA information is as expected (Y/n): y  # <-- Inconsistent.
```

### Does this PR introduce _any_ user-facing change?

No, dev-only.

### How was this patch tested?

Manually tested.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#45427 from HyukjinKwon/minor-script.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants