[SPARK-48386][TESTS] Replace JVM assert with JUnit Assert in tests #46698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it is necessary to create a jira |
Done. |
This reverts commit a776372.
panbingkun
changed the title
LuciferYang
approved these changes
May 22, 2024
| @@ -127,8 +128,8 @@ public void testBasicLoggerWithException() { | |||
| Pair.of(Level.DEBUG, debugFn), | |||
| Pair.of(Level.TRACE, traceFn)).forEach(pair -> { | |||
| try { | |||
| assert (captureLogOutput(pair.getRight()).matches( | |||
| expectedPatternForBasicMsgWithException(pair.getLeft()))); | |||
| Assertions.assertTrue(captureLogOutput(pair.getRight()).matches( | |||
There was a problem hiding this comment.
Why don't we import assertTrue?
| @@ -78,9 +80,9 @@ public Predicate[] pushPredicates(Predicate[] predicates) { | |||
|
|
|||
| Predicate[] unsupported = Arrays.stream(predicates).filter(f -> { | |||
| if (f.name().equals(">")) { | |||
| assert(f.children()[0] instanceof FieldReference); | |||
| Assertions.assertInstanceOf(FieldReference.class, f.children()[0]); | |||
There was a problem hiding this comment.
ditto. Shall we import assertInstanceOf?
|
Thank you for updating, @panbingkun . |
LuciferYang
approved these changes
May 23, 2024
|
Merged into master for Spark 4.0. Thanks @panbingkun and @dongjoon-hyun ~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to replace
JVM assertwithJUnit Assertin tests.Why are the changes needed?
assert() statements do not produce as useful errors when they fail, and, if they were somehow disabled, would fail to test anything.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No.