Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-48703][SQL][TESTS] Upgrade mssql-jdbc to 12.6.3.jre11 #47075

Closed
wants to merge 2 commits into from

Conversation

panbingkun
Copy link
Contributor

@panbingkun panbingkun commented Jun 25, 2024

What changes were proposed in this pull request?

The pr aims to upgrade mssql-jdbc from 12.6.2.jre11 to 12.6.3.jre11

Why are the changes needed?

https://github.com/microsoft/mssql-jdbc/releases/tag/v12.6.3
Hotfix & Stable Release:

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the BUILD label Jun 25, 2024
@panbingkun panbingkun marked this pull request as ready for review June 25, 2024 00:48
@panbingkun panbingkun changed the title [SPARK-48703][BUILD] Upgrade mssql-jdbc to 12.6.3.jre11 [SPARK-48703][SQL][TESTS] Upgrade mssql-jdbc to 12.6.3.jre11 Jul 4, 2024
@panbingkun
Copy link
Contributor Author

cc @HyukjinKwon

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @panbingkun .

Given that 12.7.x is preview, I'm okay with this one.

@dongjoon-hyun
Copy link
Member

Merged to master for Apache Spark 4.0.0-preview2.

attilapiros pushed a commit to attilapiros/spark that referenced this pull request Oct 4, 2024
### What changes were proposed in this pull request?
The pr aims to upgrade `mssql-jdbc` from `12.6.2.jre11` to `12.6.3.jre11`

### Why are the changes needed?
https://github.com/microsoft/mssql-jdbc/releases/tag/v12.6.3
Hotfix & Stable Release:
- Fixed issue where TokenCredential class was required to be imported microsoft/mssql-jdbc#2453
- Fixed timestamp string conversion regression microsoft/mssql-jdbc#2455
- Fixed SQLServerCallableStatement default value regression microsoft/mssql-jdbc#2456

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Pass GA.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes apache#47075 from panbingkun/SPARK-48703.

Authored-by: panbingkun <panbingkun@baidu.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
himadripal pushed a commit to himadripal/spark that referenced this pull request Oct 19, 2024
### What changes were proposed in this pull request?
The pr aims to upgrade `mssql-jdbc` from `12.6.2.jre11` to `12.6.3.jre11`

### Why are the changes needed?
https://github.com/microsoft/mssql-jdbc/releases/tag/v12.6.3
Hotfix & Stable Release:
- Fixed issue where TokenCredential class was required to be imported microsoft/mssql-jdbc#2453
- Fixed timestamp string conversion regression microsoft/mssql-jdbc#2455
- Fixed SQLServerCallableStatement default value regression microsoft/mssql-jdbc#2456

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Pass GA.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes apache#47075 from panbingkun/SPARK-48703.

Authored-by: panbingkun <panbingkun@baidu.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants