[Backport] Fixed timestamp string conversion error for cstmt (2449) #2455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed timestamp string conversion error for cstmt * Code review comments p1 * Fixed sproc used in test
Jeffery-Wasty
changed the title
Jeffery-Wasty
requested review from
lilgreenbird,
Jeffery-Wasty and
barryw-mssql
Jeffery-Wasty
previously approved these changes
Jun 19, 2024
barryw-mssql
previously approved these changes
Jun 20, 2024
Jeffery-Wasty
dismissed stale reviews from barryw-mssql and themself
via
42c463c
Jeffery-Wasty
approved these changes
Jun 20, 2024
lilgreenbird
approved these changes
Jun 20, 2024
dongjoon-hyun
pushed a commit
to apache/spark
that referenced
this pull request
Jul 22, 2024
### What changes were proposed in this pull request? The pr aims to upgrade `mssql-jdbc` from `12.6.2.jre11` to `12.6.3.jre11` ### Why are the changes needed? https://github.com/microsoft/mssql-jdbc/releases/tag/v12.6.3 Hotfix & Stable Release: - Fixed issue where TokenCredential class was required to be imported microsoft/mssql-jdbc#2453 - Fixed timestamp string conversion regression microsoft/mssql-jdbc#2455 - Fixed SQLServerCallableStatement default value regression microsoft/mssql-jdbc#2456 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #47075 from panbingkun/SPARK-48703. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
### What changes were proposed in this pull request? The pr aims to upgrade `mssql-jdbc` from `12.6.2.jre11` to `12.6.3.jre11` ### Why are the changes needed? https://github.com/microsoft/mssql-jdbc/releases/tag/v12.6.3 Hotfix & Stable Release: - Fixed issue where TokenCredential class was required to be imported microsoft/mssql-jdbc#2453 - Fixed timestamp string conversion regression microsoft/mssql-jdbc#2455 - Fixed SQLServerCallableStatement default value regression microsoft/mssql-jdbc#2456 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47075 from panbingkun/SPARK-48703. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
### What changes were proposed in this pull request? The pr aims to upgrade `mssql-jdbc` from `12.6.2.jre11` to `12.6.3.jre11` ### Why are the changes needed? https://github.com/microsoft/mssql-jdbc/releases/tag/v12.6.3 Hotfix & Stable Release: - Fixed issue where TokenCredential class was required to be imported microsoft/mssql-jdbc#2453 - Fixed timestamp string conversion regression microsoft/mssql-jdbc#2455 - Fixed SQLServerCallableStatement default value regression microsoft/mssql-jdbc#2456 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47075 from panbingkun/SPARK-48703. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #2449