Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-49234][BUILD] Upgrade xz to 1.10 #47750

Closed
wants to merge 2 commits into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Aug 14, 2024

What changes were proposed in this pull request?

This PR aims to upgrade xz to 1.10 independently from Apache Avro change.

Why are the changes needed?

1.10 is the latest minor version update with new improvements (like ARM64, optimized classes for Java >= 9) and bug fixes.

Note that the license is also changed from Public Domain to BSD Zero Clause.

Licensing change: From version 1.10 onwards, XZ for Java is under the BSD Zero Clause License (0BSD). 1.9 and older are in the public domain and obviously remain so; the change only affects the new releases.

Does this PR introduce any user-facing change?

No behavior change.

How was this patch tested?

Pass the CIs.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the BUILD label Aug 14, 2024
@dongjoon-hyun
Copy link
Member Author

Since you did xz 1.9 upgrade, WDYT, @LuciferYang ?

@@ -422,6 +422,11 @@ Python Software Foundation License
python/pyspark/loose_version.py


BSD 0-Clause
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the binary LICENSE file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, right.

Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Aug 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

licenses/LICENSE-xz.txt is added. Thank you.

@@ -0,0 +1,11 @@
Permission to use, copy, modify, and/or distribute this
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dongjoon-hyun dongjoon-hyun marked this pull request as ready for review August 14, 2024 05:34
Copy link
Contributor

@LuciferYang LuciferYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongjoon-hyun
Copy link
Member Author

Thank you, @HyukjinKwon and @LuciferYang .

@dongjoon-hyun
Copy link
Member Author

Thank you, @yaooqinn .

@LuciferYang
Copy link
Contributor

Merged into master. Thanks @dongjoon-hyun @HyukjinKwon and @yaooqinn

@dongjoon-hyun
Copy link
Member Author

Thank you again @LuciferYang .

@dongjoon-hyun dongjoon-hyun deleted the SPARK-49234 branch August 14, 2024 14:29
@@ -0,0 +1,11 @@
Permission to use, copy, modify, and/or distribute this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dongjoon-hyun

This file should be placed in the licenses-binary folder as the xz belongs to the binary releases

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IvanK-db pushed a commit to IvanK-db/spark that referenced this pull request Sep 20, 2024
### What changes were proposed in this pull request?

This PR aims to upgrade `xz` to `1.10` independently from Apache Avro change.

### Why are the changes needed?

`1.10` is the latest minor version update with new improvements (like `ARM64`, `optimized classes for Java >= 9`) and bug fixes.
- https://github.com/tukaani-project/xz-java/blob/master/NEWS.md#110-2024-07-29

Note that the license is also changed from `Public Domain` to `BSD Zero Clause`.
> Licensing change: From version 1.10 onwards, XZ for Java is under the BSD Zero Clause License (0BSD). 1.9 and older are in the public domain and obviously remain so; the change only affects the new releases.

### Does this PR introduce _any_ user-facing change?

No behavior change.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#47750 from dongjoon-hyun/SPARK-49234.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: yangjie01 <yangjie01@baidu.com>
attilapiros pushed a commit to attilapiros/spark that referenced this pull request Oct 4, 2024
### What changes were proposed in this pull request?

This PR aims to upgrade `xz` to `1.10` independently from Apache Avro change.

### Why are the changes needed?

`1.10` is the latest minor version update with new improvements (like `ARM64`, `optimized classes for Java >= 9`) and bug fixes.
- https://github.com/tukaani-project/xz-java/blob/master/NEWS.md#110-2024-07-29

Note that the license is also changed from `Public Domain` to `BSD Zero Clause`.
> Licensing change: From version 1.10 onwards, XZ for Java is under the BSD Zero Clause License (0BSD). 1.9 and older are in the public domain and obviously remain so; the change only affects the new releases.

### Does this PR introduce _any_ user-facing change?

No behavior change.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#47750 from dongjoon-hyun/SPARK-49234.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: yangjie01 <yangjie01@baidu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants