-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-49234][BUILD] Upgrade xz
to 1.10
#47750
Conversation
Since you did |
@@ -422,6 +422,11 @@ Python Software Foundation License | |||
python/pyspark/loose_version.py | |||
|
|||
|
|||
BSD 0-Clause |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to update the binary LICENSE file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
licenses/LICENSE-xz.txt
is added. Thank you.
@@ -0,0 +1,11 @@ | |||
Permission to use, copy, modify, and/or distribute this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you, @HyukjinKwon and @LuciferYang . |
Thank you, @yaooqinn . |
Merged into master. Thanks @dongjoon-hyun @HyukjinKwon and @yaooqinn |
Thank you again @LuciferYang . |
@@ -0,0 +1,11 @@ | |||
Permission to use, copy, modify, and/or distribute this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be placed in the licenses-binary folder as the xz
belongs to the binary releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @yaooqinn .
Here is the follow-up.
### What changes were proposed in this pull request? This PR aims to upgrade `xz` to `1.10` independently from Apache Avro change. ### Why are the changes needed? `1.10` is the latest minor version update with new improvements (like `ARM64`, `optimized classes for Java >= 9`) and bug fixes. - https://github.com/tukaani-project/xz-java/blob/master/NEWS.md#110-2024-07-29 Note that the license is also changed from `Public Domain` to `BSD Zero Clause`. > Licensing change: From version 1.10 onwards, XZ for Java is under the BSD Zero Clause License (0BSD). 1.9 and older are in the public domain and obviously remain so; the change only affects the new releases. ### Does this PR introduce _any_ user-facing change? No behavior change. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47750 from dongjoon-hyun/SPARK-49234. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: yangjie01 <yangjie01@baidu.com>
### What changes were proposed in this pull request? This PR aims to upgrade `xz` to `1.10` independently from Apache Avro change. ### Why are the changes needed? `1.10` is the latest minor version update with new improvements (like `ARM64`, `optimized classes for Java >= 9`) and bug fixes. - https://github.com/tukaani-project/xz-java/blob/master/NEWS.md#110-2024-07-29 Note that the license is also changed from `Public Domain` to `BSD Zero Clause`. > Licensing change: From version 1.10 onwards, XZ for Java is under the BSD Zero Clause License (0BSD). 1.9 and older are in the public domain and obviously remain so; the change only affects the new releases. ### Does this PR introduce _any_ user-facing change? No behavior change. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47750 from dongjoon-hyun/SPARK-49234. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: yangjie01 <yangjie01@baidu.com>
What changes were proposed in this pull request?
This PR aims to upgrade
xz
to1.10
independently from Apache Avro change.Why are the changes needed?
1.10
is the latest minor version update with new improvements (likeARM64
,optimized classes for Java >= 9
) and bug fixes.Note that the license is also changed from
Public Domain
toBSD Zero Clause
.Does this PR introduce any user-facing change?
No behavior change.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.