Skip to content

Commit

Permalink
chore: allow codecov to detect SHA (#28278)
Browse files Browse the repository at this point in the history
  • Loading branch information
mistercrunch authored and michael-s-molina committed May 2, 2024
1 parent 7840afb commit b7534a0
Show file tree
Hide file tree
Showing 6 changed files with 48 additions and 1,953 deletions.
13 changes: 0 additions & 13 deletions .github/workflows/bashlib.sh
Original file line number Diff line number Diff line change
Expand Up @@ -129,12 +129,6 @@ testdata() {
say "::endgroup::"
}

codecov() {
say "::group::Upload code coverage"
bash ".github/workflows/codecov.sh" "$@"
say "::endgroup::"
}

cypress-install() {
cd "$GITHUB_WORKSPACE/superset-frontend/cypress-base"

Expand Down Expand Up @@ -201,11 +195,6 @@ cypress-run-all() {

cypress-run "sqllab/*" "Backend persist"

# Upload code coverage separately so each page can have separate flags
# -c will clean existing coverage reports, -F means add flags
# || true to prevent CI failure on codecov upload
codecov -c -F "cypress" || true

say "::group::Flask log for backend persist"
cat "$flasklog"
say "::endgroup::"
Expand Down Expand Up @@ -235,8 +224,6 @@ cypress-run-applitools() {

$cypress --spec "cypress/e2e/*/**/*.applitools.test.ts" --browser "$browser" --headless --config ignoreTestFiles="[]"

codecov -c -F "cypress" || true

say "::group::Flask log for default run"
cat "$flasklog"
say "::endgroup::"
Expand Down
Loading

0 comments on commit b7534a0

Please sign in to comment.