chore: allow codecov to detect SHA #28278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In our CI, where codecov.sh is called, there's a message from its CLI saying `Issue detecting commit SHA. Please run actions/checkout with fetch-depth > 1 or set to 0`. From my understanding setting depth=2 should allow to resolve this, without having much impact on cloning workload.
mistercrunch
requested review from
villebro,
geido,
eschutho,
rusackas,
betodealmeida,
nytai,
craig-rueda,
john-bodley,
kgabryje and
dpgaspar
as code owners
|
We would appreciate it if you could provide us with more info about this issue/pr! Please do not leave the |
github-actions
bot
added
the
github_actions
eschutho
approved these changes
Apr 30, 2024
|
Switching to https://github.com/codecov/codecov-action may be the best option, for now we just need to unblock this. Anyone looking at these reports? |
rusackas
reviewed
Apr 30, 2024
| @@ -67,6 +68,9 @@ jobs: | |||
| ./scripts/python_tests.sh | |||
| - name: Upload code coverage | |||
| if: steps.check.outputs.python | |||
| continue-on-error: true # codecob is not critical and randomly fails at times | |||
There was a problem hiding this comment.
Suggested change
| continue-on-error: true # codecob is not critical and randomly fails at times | |
| continue-on-error: true # codecov is not critical and randomly fails at times |
Code on the Cob?! Sign me up!
This still upholds/blocks on the standards (e.g. core packages at 100% coverage) right?
rusackas
reviewed
Apr 30, 2024
rusackas
reviewed
Apr 30, 2024
rusackas
reviewed
Apr 30, 2024
rusackas
reviewed
Apr 30, 2024
rusackas
reviewed
Apr 30, 2024
|
Ok I ended up setting up the official GHA, allowed me to delete that heavy |
michael-s-molina
added
v4.0
michael-s-molina
pushed a commit
that referenced
this pull request
May 2, 2024
michael-s-molina
pushed a commit
that referenced
this pull request
May 2, 2024
jzhao62
pushed a commit
to jzhao62/superset
that referenced
this pull request
May 16, 2024
mistercrunch
added
🍒 4.0.2
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our CI, where codecov.sh is called, there's a message from its CLI saying
Issue detecting commit SHA. Please run actions/checkout with fetch-depth > 1 or set to 0. From my understanding setting depth=2 should allow to resolve this, without having much impact on cloning workload.