Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: allow codecov to detect SHA #28278

Merged
merged 7 commits into from
Apr 30, 2024
Merged

chore: allow codecov to detect SHA #28278

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fddda37
chore: allow codecov to detect SHA
mistercrunch Apr 30, 2024
73fab2c
more tokens
mistercrunch Apr 30, 2024
9d1c0f4
lower retries
mistercrunch Apr 30, 2024
cdcc6ee
more codecov fixes
mistercrunch Apr 30, 2024
038b4c0
no retry
mistercrunch Apr 30, 2024
b0bf17d
using the github action
mistercrunch Apr 30, 2024
97f680a
rm depth, set flags
mistercrunch Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/codecov.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1832,7 +1832,6 @@ else
say "$url/upload/v4?$queryNoToken"
# shellcheck disable=SC2086,2090
res=$(curl $curl_s -X POST $cacert \
--retry 5 --retry-delay 2 --connect-timeout 2 \
-H 'X-Reduced-Redundancy: false' \
-H 'X-Content-Type: application/x-gzip' \
-H 'Content-Length: 0' \
Expand Down Expand Up @@ -1878,7 +1877,6 @@ else
# shellcheck disable=SC2086,2090
res=$(curl -X POST $cacert \
--data-binary @"$upload_file.gz" \
--retry 5 --retry-delay 2 --connect-timeout 2 \
-H 'Content-Type: text/plain' \
-H 'Content-Encoding: gzip' \
-H 'X-Content-Encoding: gzip' \
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/superset-frontend.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
uses: actions/checkout@v4
with:
fetch-depth: 0 # Fetch all history
fetch-depth: 2 # codecov needs 2 to get a read on the SHA
mistercrunch marked this conversation as resolved.
Show resolved Hide resolved
persist-credentials: false
submodules: recursive
- name: Check npm lock file version
Expand Down Expand Up @@ -80,6 +80,7 @@ jobs:
run: npx jest
- name: Upload code coverage
if: steps.check.outputs.frontend
continue-on-error: true # codecob is not critical and randomly fails at times
working-directory: ./superset-frontend
run: ../.github/workflows/codecov.sh -c -F javascript
env:
Expand Down
11 changes: 11 additions & 0 deletions .github/workflows/superset-python-integrationtest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ jobs:
uses: actions/checkout@v4
with:
persist-credentials: false
fetch-depth: 2 # codecov needs 2 to get a read on the SHA
submodules: recursive
- name: Check for file changes
id: check
Expand All @@ -67,6 +68,9 @@ jobs:
./scripts/python_tests.sh
- name: Upload code coverage
if: steps.check.outputs.python
continue-on-error: true # codecob is not critical and randomly fails at times
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
continue-on-error: true # codecob is not critical and randomly fails at times
continue-on-error: true # codecov is not critical and randomly fails at times

Code on the Cob?! Sign me up!

This still upholds/blocks on the standards (e.g. core packages at 100% coverage) right?

env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
run: |
bash .github/workflows/codecov.sh -c -F python -F mysql
test-postgres:
Expand Down Expand Up @@ -124,6 +128,9 @@ jobs:
./scripts/python_tests.sh
- name: Upload code coverage
if: steps.check.outputs.python
continue-on-error: true # codecob is not critical and randomly fails at times
mistercrunch marked this conversation as resolved.
Show resolved Hide resolved
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
run: |
bash .github/workflows/codecov.sh -c -F python -F postgres

Expand All @@ -148,6 +155,7 @@ jobs:
with:
persist-credentials: false
submodules: recursive
fetch-depth: 2 # codecov needs 2 to get a read on the SHA
- name: Check for file changes
id: check
uses: ./.github/actions/change-detector/
Expand All @@ -172,5 +180,8 @@ jobs:
./scripts/python_tests.sh
- name: Upload code coverage
if: steps.check.outputs.python
continue-on-error: true # codecob is not critical and randomly fails at times
mistercrunch marked this conversation as resolved.
Show resolved Hide resolved
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
run: |
bash .github/workflows/codecov.sh -c -F python -F sqlite
4 changes: 4 additions & 0 deletions .github/workflows/superset-python-presto-hive.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ jobs:
with:
persist-credentials: false
submodules: recursive
fetch-depth: 2 # codecov needs 2 to get a read on the SHA
- name: Check for file changes
id: check
uses: ./.github/actions/change-detector/
Expand Down Expand Up @@ -139,5 +140,8 @@ jobs:
./scripts/python_tests.sh -m 'chart_data_flow or sql_json_flow'
- name: Upload code coverage
if: steps.check.outputs.python
continue-on-error: true # codecob is not critical and randomly fails at times
mistercrunch marked this conversation as resolved.
Show resolved Hide resolved
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
run: |
bash .github/workflows/codecov.sh -c -F python -F hive
4 changes: 4 additions & 0 deletions .github/workflows/superset-python-unittest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ jobs:
with:
persist-credentials: false
submodules: recursive
fetch-depth: 2 # codecov needs 2 to get a read on the SHA
- name: Check for file changes
id: check
uses: ./.github/actions/change-detector/
Expand All @@ -47,5 +48,8 @@ jobs:
pytest --durations-min=0.5 --cov-report= --cov=superset ./tests/common ./tests/unit_tests --cache-clear
- name: Upload code coverage
if: steps.check.outputs.python
continue-on-error: true # codecob is not critical and randomly fails at times
mistercrunch marked this conversation as resolved.
Show resolved Hide resolved
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
run: |
bash .github/workflows/codecov.sh -c -F python -F unit
Loading