Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard][cosmetic]undo and redo buttons weird alignment #16365

Closed
junlincc opened this issue Aug 20, 2021 · 1 comment · Fixed by #16417
Closed

[dashboard][cosmetic]undo and redo buttons weird alignment #16365

junlincc opened this issue Aug 20, 2021 · 1 comment · Fixed by #16417
Labels
#bug:cosmetic Cosmetic/layout/design tweak needed good first issue Good first issues for new contributors P4 Priority item - Low

Comments

@junlincc
Copy link
Member

junlincc commented Aug 20, 2021 •
edited
Loading

  1. I'm not sure where else in the product is using these unicorns, the purpose of these icons seem unclear to me. and they are not even centered. 🤦🏾‍♀️
Screen.Recording.2021-08-19.at.8.06.37.PM.mov

we could consider go straight to implement new design in sip 34, or simply center the icon for now. low priority.
@junlincc junlincc added #bug:cosmetic Cosmetic/layout/design tweak needed viz:dashboard:ui P4 Priority item - Low labels Aug 20, 2021
@junlincc junlincc added the good first issue Good first issues for new contributors label Aug 21, 2021
@junlincc
Copy link
Member Author

junlincc commented Aug 21, 2021 •
edited
Loading

@MaxHuiYYDS wanna try fixing this one?

This was referenced Aug 21, 2021
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
#bug:cosmetic Cosmetic/layout/design tweak needed good first issue Good first issues for new contributors P4 Priority item - Low
Projects
None yet
Milestone
No milestone
2 participants
@junlincc @michael-s-molina