fix(1:dashboard-ui,2:Explore control panel): 1:undo and redo buttons weird alignment. 2:Keyboard navigation in Explore control panel #16389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updating makefile * Update Makefile
* fix: update table ID in query context on chart import * Fix test
* Email Report Modal validation testing * Starting RTL testing for email report * Calendar icon now rendering! * Create report testing in dashboard * make linter happy * Fixing weird error * Removed ExploreChartHeader_spec * Fixed dashboard header test * revert changes from merge * Fix tests Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
MaxHuiYYDS
changed the title
|
@MaxHuiYYDS Thanks for the contribution. Could you split this into two PRs? It seems the two changes are not related. |
|
@MaxHuiYYDS please do split this PR into 2, and attach separate issues to them. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
1:dashboard-ui:
I think it related to PR #13037, which help add 8px marginRight when there are more than one element. But it may not apply for this situation, in order not to affect other components, I add the showMarginRight prop in Button Component.
2:Explore control panel:
I added hideNativeTab prop at ControlHeader in selectControl, when the native keyboard Tab actions need to omit the headers, then define the hideNativeTab to true.
###: BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
1:dashboard-ui: BEFORE：
1:dashboard-ui: AFTER：
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
2:Explore control panel: AFTER：
Screen.Recording.2021-08-22.at.8.40.08.PM.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION