-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(explore): skip Tab focus on control headers #16418
Conversation
/testenv up |
@junlincc Container image not yet published for this PR. Please try again when build is complete. |
@junlincc Ephemeral environment creation failed. Please check the Actions logs for details. |
Codecov Report
@@ Coverage Diff @@
## master #16418 +/- ##
==========================================
+ Coverage 76.55% 76.70% +0.14%
==========================================
Files 1000 1002 +2
Lines 53487 53683 +196
Branches 6818 6855 +37
==========================================
+ Hits 40948 41176 +228
+ Misses 12301 12270 -31
+ Partials 238 237 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM but not sure why CI is failing though. Will stamp once CI is fixed.
@ktmud I have Annotated some button click test, to make this PR pass the test, please help review. |
Do we know why the tests fail? We can't just disable tests unless the change of behavior is intentional. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue |
SUMMARY
Explore control panel:
I added hideNativeTab prop at ControlHeader in selectControl, when the native keyboard Tab actions need to omit the headers, then define the hideNativeTab to true.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
AFTER:
Screen.Recording.2021-08-22.at.8.40.08.PM.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION