refactor: useListViewResource hook for charts, dashboards, datasets

[nytai]

SUMMARY

• converts DashboardList and ChartList to a function components
• extracts out common list view code into a useListViewResource hook

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

• CI, functionality is unchanged

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[nytai]

oops

[codecov-commenter]

Codecov Report

Merging #10680 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10680      +/-   ##
==========================================
- Coverage   59.53%   59.39%   -0.15%     
==========================================
  Files         360      360              
  Lines       23173    23173              
==========================================
- Hits        13796    13763      -33     
- Misses       9377     9410      +33     

Flag	Coverage Δ
#python	59.39% <ø> (-0.15%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/views/database/mixins.py	59.64% <0.00%> (-21.06%)	⬇️
superset/views/database/validators.py	78.94% <0.00%> (-5.27%)	⬇️
superset/views/base_api.py	94.18% <0.00%> (-4.07%)	⬇️
superset/databases/api.py	85.18% <0.00%> (-2.78%)	⬇️
superset/db_engine_specs/postgres.py	97.43% <0.00%> (-2.57%)	⬇️
superset/views/database/views.py	85.93% <0.00%> (-1.57%)	⬇️
superset/models/core.py	85.27% <0.00%> (-1.12%)	⬇️
superset/jinja_context.py	80.00% <0.00%> (-0.96%)	⬇️
superset/db_engine_specs/base.py	87.60% <0.00%> (-0.28%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc0fc4e...260b22a. Read the comment docs.

[willbarrett]

nit unrelated to this PR, and out of scope for this change: it would be good to make this a positive setting rather than a negated setting, so rather than disableSortBy: true, it could be more readable to have the option sortingEnabled: false.

[nytai]

originally the property was called "sortable" however there were a few type errors creeped up so I opted to use react-table's included property https://react-table.tanstack.com/docs/api/useSortBy#table-options

If time permits I'll do a second pass at trying to clean up the columns config api.

[willbarrett]

Understood. Please don't burn too many cycles on it given that it maps onto a 3rd party library's naming. Just a passing thought.

[rusackas]

LGTM! You've done a great job with this... but man, that Favorites star does a LOT of work. In a more perfect world, the favorite status would just be part of the chart/dash array, so you don't have to do all these API calls and whatnot.