Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: useListViewResource hook for charts, dashboards, datasets #10680

Merged
merged 13 commits into from
Aug 26, 2020
+1,216 −1,331
Merged

refactor: useListViewResource hook for charts, dashboards, datasets #10680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9acc7f9
refactor: convert DashboardList to a function component
nytai Aug 21, 2020
33e16a6
refactor: convert ChartList to a function component
nytai Aug 21, 2020
555cc19
refactor: convert DatasetList to a function component
nytai Aug 21, 2020
912203e
fix: use functional state update, optimize favestar fetching
nytai Aug 21, 2020
72473ee
guard against empty owners
nytai Aug 21, 2020
9194136
refactor: convert ChartList to use new ListViewResource hook
nytai Aug 26, 2020
c7b68a9
refactor: convert DatasetList and ChartList to useListViewResource
nytai Aug 26, 2020
6a1afec
fix specs, tidy up
nytai Aug 26, 2020
ad2d88d
fix plural
nytai Aug 26, 2020
8e6e211
fix FaveStar issues with infinite remounting
nytai Aug 26, 2020
a4b0fc3
move fetchFaveStar methods into useFaveStar hook
nytai Aug 26, 2020
260b22a
fix: createErrorHandler function using wrong key on error object
nytai Aug 26, 2020
1319fdc
fix comment
nytai Aug 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions superset-frontend/spec/javascripts/views/CRUD/chart/ChartList_spec.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,18 +17,18 @@
* under the License.
*/
import React from 'react';
import { mount } from 'enzyme';
import thunk from 'redux-thunk';
import configureStore from 'redux-mock-store';
import fetchMock from 'fetch-mock';
import { supersetTheme, ThemeProvider } from '@superset-ui/style';

import waitForComponentToPaint from 'spec/helpers/waitForComponentToPaint';
import { styledMount as mount } from 'spec/helpers/theming';

import ChartList from 'src/views/CRUD/chart/ChartList';
import ConfirmStatusChange from 'src/components/ConfirmStatusChange';
import ListView from 'src/components/ListView';
import PropertiesModal from 'src/explore/components/PropertiesModal';
import ListViewCard from 'src/components/ListViewCard';

// store needed for withToasts(ChartTable)
const mockStore = configureStore([thunk]);
const store = mockStore({});
Expand Down Expand Up @@ -78,8 +78,10 @@ describe('ChartList', () => {
const mockedProps = {};
const wrapper = mount(<ChartList {...mockedProps} />, {
context: { store },
wrappingComponent: ThemeProvider,
wrappingComponentProps: { theme: supersetTheme },
});

beforeAll(async () => {
await waitForComponentToPaint(wrapper);
});

it('renders', () => {
Expand Down
11 changes: 7 additions & 4 deletions superset-frontend/spec/javascripts/views/CRUD/dashboard/DashboardList_spec.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,12 @@
* under the License.
*/
import React from 'react';
import { mount } from 'enzyme';
import thunk from 'redux-thunk';
import configureStore from 'redux-mock-store';
import fetchMock from 'fetch-mock';
import { supersetTheme, ThemeProvider } from '@superset-ui/style';

import waitForComponentToPaint from 'spec/helpers/waitForComponentToPaint';
import { styledMount as mount } from 'spec/helpers/theming';

import ConfirmStatusChange from 'src/components/ConfirmStatusChange';
import DashboardList from 'src/views/CRUD/dashboard/DashboardList';
Expand Down Expand Up @@ -69,8 +70,10 @@ describe('DashboardList', () => {
const mockedProps = {};
const wrapper = mount(<DashboardList {...mockedProps} />, {
context: { store },
wrappingComponent: ThemeProvider,
wrappingComponentProps: { theme: supersetTheme },
});

beforeAll(async () => {
await waitForComponentToPaint(wrapper);
});

it('renders', () => {
Expand Down
Loading