feat: add source tab to DatasourceEditor #10731
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
force-pushed
the
datasource_editor_source
branch
2 times, most recently
from
9c943e3 to
faf9baa
Compare
Codecov Report
@@ Coverage Diff @@
## master #10731 +/- ##
==========================================
- Coverage 60.87% 60.66% -0.21%
==========================================
Files 803 803
Lines 37928 37938 +10
Branches 3561 3570 +9
==========================================
- Hits 23088 23015 -73
- Misses 14654 14737 +83
Partials 186 186
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mistercrunch
force-pushed
the
datasource_editor_source
branch
4 times, most recently
from
c648e14 to
8d9210a
Compare
mistercrunch
commented
Sep 9, 2020
| @@ -831,10 +831,6 @@ def test_export_dataset(self): | |||
| self.login(username="admin") | |||
| rv = self.get_assert_metric(uri, "export") | |||
| self.assertEqual(rv.status_code, 200) | |||
| self.assertEqual( | |||
There was a problem hiding this comment.
This was having mismatch timestamp on filename
mistercrunch
commented
Sep 9, 2020
tests/datasets/api_tests.py
Outdated
| @@ -849,7 +845,9 @@ def test_export_dataset(self): | |||
| expected_response = export_table | |||
| break | |||
| ui_export = yaml.safe_load(rv.data.decode("utf-8")) | |||
| self.assertEqual(ui_export[0], expected_response) | |||
| # TODO re-enable flaky next line | |||
There was a problem hiding this comment.
https://github.com/apache/incubator-superset/pull/10731/checks?check_run_id=1091887012
for reference:
=================================== FAILURES ===================================
______________________ TestDatasetApi.test_export_dataset ______________________
self = <tests.datasets.api_tests.TestDatasetApi testMethod=test_export_dataset>
8d9210a to
895e510
Compare
6 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add a
Sourcetab to the dataset editorTODO: expose database/schema selector on virtual dataset, this will require some refactoring around
TableSelectorBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF