fix: Making the database/cluster read-only #10823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
changed the title
Codecov Report
@@ Coverage Diff @@
## master #10823 +/- ##
==========================================
- Coverage 65.43% 61.21% -4.22%
==========================================
Files 803 803
Lines 37930 37935 +5
Branches 3561 3561
==========================================
- Hits 24818 23223 -1595
- Misses 13008 14526 +1518
- Partials 104 186 +82
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
john-bodley
force-pushed
the
john-bodley--database-read-only
branch
from
368babf to
b00acd8
Compare
|
related: #10731, I could add this logic into my PR We're looking to deprecate the CRUD for tables soon-ish. |
dpgaspar
approved these changes
Sep 10, 2020
| @@ -160,7 +160,7 @@ class TableColumnInlineView( # pylint: disable=too-many-ancestors | |||
| add_form_extra_fields = { | |||
| "table": QuerySelectField( | |||
| "Table", | |||
| query_factory=lambda: db.session().query(models.SqlaTable), | |||
| query_factory=lambda: db.session.query(models.SqlaTable), | |||
| "cluster": QuerySelectField( | ||
| "Cluster", | ||
| query_factory=lambda: db.session.query(models.DruidCluster), | ||
| widget=Select2Widget(extra_classes="readonly"), |
There was a problem hiding this comment.
I'll make a patch release for FAB to make the readonly work again
dpgaspar/Flask-AppBuilder#1467
john-bodley
added a commit
to airbnb/superset-fork
that referenced
this pull request
Sep 10, 2020
Co-authored-by: John Bodley <john.bodley@airbnb.com> (cherry picked from commit a3e2e65)
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
Co-authored-by: John Bodley <john.bodley@airbnb.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR makes a few related consistency updates to ensure that the database/cluster et al. is read-only either in the FAB CRUD or React data editor. Note one could reason that you could potential make the schema, table, etc. read-only, though my sense is that is that could be somewhat controversial.
Specially this PR:
@dpgaspar I noticed that there seems to have been a regression in FAB and the read-only selector logic which we are using (per the documentation) no longer works. I've also verified this using the FAB examples and was wondering whether you could look into it?
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE
AFTER
TEST PLAN
Tested locally.
ADDITIONAL INFORMATION