-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore '/docs' on some GH actions, give docs its own action #10949
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment. Agree that we want TS in docs :). Otherwise LGTM
This change makes it so that PRs with only changes to |
@nytai @craig-rueda @ktmud I really want it to work though, since there are surely other checks that could be bypassed in numerous PR scenarios, in order to make things faster and (probably) less flake-prone. |
@rusackas The only thing I can think of is to build the file/path checking step into the actual test code. I did something like this for the fossa check a while back, https://github.com/preset-io/incubator-superset/blob/master/.github/workflows/license-check.yml#L36 |
@@ -1,6 +1,12 @@ | |||
name: Frontend | |||
|
|||
on: [push, pull_request] | |||
on: | |||
push: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh nice I didn't know you could do this! GH actions ftw!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My original GA implementation actually had some path ignores, but was removed out of abundance of caution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the main issue is that the check cannot be conditionally run and required. We'd have to make all these checks not required and rely on reviewers/mergers to use their best judgement when merging.
…0949) * ignore docs on several actions, give docs its own action * Random doc change to see if the new action runs. * umm... not paths-ignore, paths! * eof fix * enabling typescript checking on docs
SUMMARY
First time fiddling with GitHub Actions... be kind to me :)
Attempting to skip several checks for file changes within the
/docs
directory. Also adding a new action that lints/builds the docs, only when files in/docs
are changed.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
Gonna tweak a few files herein, and see how it responds.
ADDITIONAL INFORMATION