Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore '/docs' on some GH actions, give docs its own action #10949

Merged
merged 7 commits into from
Sep 18, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions .github/workflows/superset-docs.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
name: Docs

on:
push:
paths:
- 'docs/**'
pull_request:
paths:
- 'docs/**'

jobs:
docs:
name: build
runs-on: ubuntu-18.04
steps:
- name: Checkout code
uses: actions/checkout@v2
- name: Install dependencies
- name: npm install
working-directory: ./docs
run: |
npm install
- name: lint
working-directory: ./docs
run: |
npm run lint
- name: gatsby build
working-directory: ./docs
run: |
npm run build
8 changes: 7 additions & 1 deletion .github/workflows/superset-e2e.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
name: E2E

on: [push, pull_request]
on:
push:
paths-ignore:
- 'docs/**'
pull_request:
paths-ignore:
- 'docs/**'

jobs:
Cypress:
Expand Down
23 changes: 7 additions & 16 deletions .github/workflows/superset-frontend.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
name: Frontend

on: [push, pull_request]
on:
push:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh nice I didn't know you could do this! GH actions ftw!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My original GA implementation actually had some path ignores, but was removed out of abundance of caution.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the main issue is that the check cannot be conditionally run and required. We'd have to make all these checks not required and rely on reviewers/mergers to use their best judgement when merging.

paths-ignore:
- 'docs/**'
pull_request:
paths-ignore:
- 'docs/**'

jobs:
build:
Expand All @@ -25,18 +31,3 @@ jobs:
working-directory: ./superset-frontend
run: |
bash <(curl -s https://codecov.io/bash) -cF javascript

docs:
rusackas marked this conversation as resolved.
Show resolved Hide resolved
name: build
runs-on: ubuntu-18.04
steps:
- name: Checkout code
uses: actions/checkout@v2
- name: Install dependencies
working-directory: ./superset-frontend
run: |
npm install
- name: gatsby build
working-directory: ./superset-frontend
run: |
npm run build
8 changes: 7 additions & 1 deletion .github/workflows/superset-python.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
# Python unit tests
name: Python

on: [push, pull_request]
on:
push:
paths-ignore:
- 'docs/**'
pull_request:
paths-ignore:
- 'docs/**'

jobs:
lint:
Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/test-hive.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
name: Hive

on: [push, pull_request]
on:
push:
paths-ignore:
- 'docs/**'
pull_request:
paths-ignore:
- 'docs/**'

jobs:
test-postgres-hive:
Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/test-presto.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
name: Presto

on: [push, pull_request]
on:
push:
paths-ignore:
- 'docs/**'
pull_request:
paths-ignore:
- 'docs/**'

jobs:
test-postgres-presto:
Expand Down
2 changes: 1 addition & 1 deletion docs/src/pages/404.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const NotFoundPage = () => (
<Layout>
<SEO title="404: Not found" />
<h1>NOT FOUND</h1>
<p>You just hit a route that does not exist... the sadness.</p>
rusackas marked this conversation as resolved.
Show resolved Hide resolved
<p>Sorry, you've requested a page that does not exist.</p>
</Layout>
);

Expand Down