feat: add certification info to table selector #11785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11785 +/- ##
==========================================
- Coverage 67.20% 63.35% -3.85%
==========================================
Files 903 905 +2
Lines 43719 43867 +148
Branches 4199 4205 +6
==========================================
- Hits 29380 27791 -1589
- Misses 14235 15896 +1661
- Partials 104 180 +76
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
etr2460
force-pushed
the
erik-ritter--table-certification-selector
branch
3 times, most recently
from
a533ead to
233f226
Compare
ktmud
approved these changes
Nov 24, 2020
superset/connectors/sqla/models.py
Outdated
| return json.loads(self.extra) | ||
| except (TypeError, json.JSONDecodeError): | ||
| return {} | ||
|
|
There was a problem hiding this comment.
Wdyt of making this be a @property?
etr2460
force-pushed
the
erik-ritter--table-certification-selector
branch
from
233f226 to
a9891d0
Compare
9 tasks
john-bodley
added a commit
to john-bodley/superset
that referenced
this pull request
Jul 28, 2022
john-bodley
added a commit
that referenced
this pull request
Jul 29, 2022
mistercrunch
added
the
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The current table selector only gets table names from the database engine itself, and leaves out any additional metadata a user may have provided to a physical dataset. This merges the tables list returned from the database with any extra metadata from the datasets so we can display certification status in table selectors throughout the product
AFTER SCREENSHOTS
TEST PLAN
ADDITIONAL INFORMATION
to: @ktmud @graceguo-supercat @bkyryliuk @john-bodley