fix: do not show vertical scrollbar for charts in dashboard #12478

graceguo-supercat · 2021-01-12T23:13:29Z

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

rusackas · 2021-01-12T23:20:29Z

I was looking at the same approach, but this does have a side effect... in some situations, particularly with Filter Box, the options spill over, and can't be seen/clicked.

graceguo-supercat · 2021-01-12T23:25:10Z

I am not sure how to reproduce the screenshot :) Do you make filter_box container really small?

rusackas · 2021-01-12T23:31:03Z

I am not sure how to reproduce the screenshot :) Do you make filter_box container really small?

Exactly... I rejiggered the layout, and made the filter box short. Kind of a mean edge case, I admit, but the problem may exist if there are a lot of filters added to a filter box.

Good news is, I think I see another possible approach. I'll kick the tires a little more and open a PR in a few minutes for evaluation.

codecov-io · 2021-01-12T23:34:11Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.16%. Comparing base (e47350e) to head (f2b0f07).
Report is 9420 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (e47350e) and HEAD (f2b0f07). Click for more details.

HEAD has 5 uploads less than BASE

Flag BASE (e47350e) HEAD (f2b0f07)

python 10 6

javascript 1 0

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #12478      +/-   ##
==========================================
- Coverage   66.82%   59.16%   -7.67%     
==========================================
  Files        1015      959      -56     
  Lines       49555    46792    -2763     
  Branches     5079     4341     -738     
==========================================
- Hits        33116    27685    -5431     
- Misses      16309    19107    +2798     
+ Partials      130        0     -130

Flag	Coverage Δ
cypress	`50.99% <100.00%> (-0.01%)`	⬇️
javascript	`?`
python	`63.77% <ø> (-0.32%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ktmud · 2021-01-12T23:52:05Z

@rusackas I just pushed a fix.

rusackas · 2021-01-12T23:54:06Z

Me too: #12479

ktmud · 2021-01-12T23:57:29Z

For transparency, what I did is reverting #11580 and adding a proper fix for #11419 , making chart header sticky as mentioned in #11580 (comment) .

Chart renders do have access to parent container size, you just need to pass it on in transformProps.

In general, charts should handle their own scrollable areas, the chart container should always be unscrollable. We will make sure wherever the charts are rendered, the correct parent size is passed to SuperChart.

ktmud · 2021-01-12T23:58:46Z

Also related: #12153

rusackas

LGTM! Less LESS! I like the per-plugin responsibility for setting scroll capability. Seems to work great after some manual testing. Thanks for the quick turnaround @ktmud!

* fix: do not show vertical scrollbar for charts in dashboard * Proper fix for #11419 Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>

…2478) * fix: do not show vertical scrollbar for charts in dashboard * Proper fix for apache#11419 Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>

* release: bump to 1.0.0 and CHANGELOG * fix(explore): long metric name display (#12387) * fix(explore): long metric name display * add tooltip to control * chore: Show datasets when search input is empty (#12391) * chore: Fix typo “Rest” to “Reset” (#12392) * chore: upgrade eslint, babel, and prettier (#12393) * feat(explore): add tooltip to timepicker label (#12401) * chore: change Datasource to Dataset in Explore ui (#12402) * chore(explore):change dataset to datasource in ui * modal * Add space * Changing it back🤦🏾‍♀️ * Chargeback * fix: Refresh Interval Modal dropdown (#12406) * fix(native-filters): incorrect queriesData state (#12409) * refactor: from superset.utils.core break down date_parser (#12408) * Fixes control panel fields styling (#12236) (#12326) * feat: Resizable dataset and controls panels on Explore view (#12411) * Implement resizable panels on explore view * Optimize chart rendering while resizing * Make dataset column narrower Co-authored-by: Evan Rusackas <evan@preset.io> * fix(dashboard): artefacts shown while drag and dropping deck.gl charts (#12418) * [12181] Fix artifacts while drag and dropping deck.gl charts. * Run prettier * bump superset-ui packages for rolling window change (#12426) * chore: bump superset-ui deckgl plugin (#12466) * fix: do not show vertical scrollbar for charts in dashboard (#12478) * fix: do not show vertical scrollbar for charts in dashboard * Proper fix for #11419 Co-authored-by: Jesse Yang <jesse.yang@airbnb.com> * fix(dashboard): use datasource id from slice metadata (#12483) * fix(timepicker): make pyparsing thread safe (#12489) * fix: make pyparsing thread safe * remove parenthesis for decorator * fix (SQL Lab): disappearing results on tab switch (#12472) * fix (SQL Lab): disappearing results on tab switch * Remove state * Fix test * fix: import ZIP files that have been modified (#12425) * fix: import ZIP files that have been modified * Add unit test * update changelog with rc2 entries * fix: impose dataset ownership check on old API (#12491) * fix: impose dataset ownership check on old API * update UPDATING.md * partially protect the old MVC also * prevent metric and column add and update * ci: remove refs/tags from docker tags on a release (#12518) * ci: remove refs/tags from docker tags on a release * wider head * fix: lowercase all columns in examples (#12530) * fix(explore): time table control panel (#12532) * fix(explore): Add Time section back to FilterBox (#12537) * Fixing Pinot queries for time granularities: WEEKS/MONTHS/QUARTERS/YEARS (#12536) * fix: Select options overflowing Save chart modal on Explore view (#12522) * Fix select options overflowing modal * fix unit test Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> * Fix list filters vertical alignment (#12497) * feat(db-engine): Add support for Apache Solr (#12403) * [db engine] Add support for Apache Solr * Fixing typo * chore: rename docker image in build_docker_image.sh, docker-compose.yml and helm values.yaml (#12337) * add rc3 changelog entries * fix: Popover closes on change of dropdowns values (#12410) * fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN (#12555) * fix(viz): missing groupby and broken adhoc metrics for boxplot (#12556) * fix: height on grid results (#12558) * fix: case expression should not have double quotes (#12562) * Fix 500 error when loading dashboards with slice having deleted dataset (#12535) * add rc4 changelog entries * Fixed typo on line 348 * Added files Co-authored-by: Daniel Gaspar <danielvazgaspar@gmail.com> Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com> Co-authored-by: Geido <60598000+geido@users.noreply.github.com> Co-authored-by: Junlin Chen <junlin@preset.io> Co-authored-by: Jesse Yang <jesse.yang@airbnb.com> Co-authored-by: Agata Stawarz <47450693+agatapst@users.noreply.github.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> Co-authored-by: Evan Rusackas <evan@preset.io> Co-authored-by: Kasia Kucharczyk <2536609+kkucharc@users.noreply.github.com> Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com> Co-authored-by: Grace Guo <grace.guo@airbnb.com> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> Co-authored-by: Xiang Fu <fx19880617@gmail.com> Co-authored-by: Ahmed Adel <github@aadel.io> Co-authored-by: Amit Miran <47772523+amitmiran137@users.noreply.github.com> Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com> Co-authored-by: Shuyao Bi <shuyaob@andrew.cmu.edu> Co-authored-by: Lyndsi Kay Williams <lyndsikaywilliams@Lyndsis-MacBook-Pro.local>

fix: do not show vertical scrollbar for charts in dashboard

5ae7ae7

pull-request-size bot added the size/XS label Jan 12, 2021

pull-request-size bot added size/S and removed size/XS labels Jan 12, 2021

Proper fix for apache#11419

f2b0f07

ktmud force-pushed the gg-RemoveVerticalScrollbar branch from 660f879 to f2b0f07 Compare January 13, 2021 00:00

ktmud mentioned this pull request Jan 13, 2021

fix: removing dashboard scrollbars #12479

Closed

6 tasks

rusackas approved these changes Jan 13, 2021

View reviewed changes

ktmud merged commit e9d66e9 into apache:master Jan 13, 2021

junlincc added the v1.0 label Jan 13, 2021

villebro pushed a commit that referenced this pull request Jan 13, 2021

fix: do not show vertical scrollbar for charts in dashboard (#12478)

b3e7ef2

* fix: do not show vertical scrollbar for charts in dashboard * Proper fix for #11419 Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>

junlincc mentioned this pull request Jan 19, 2021

Scroll Bars on all charts even if they shouldn't be there #12597

Closed

mistercrunch added 🍒 1.0.0 🍒 1.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: do not show vertical scrollbar for charts in dashboard #12478

fix: do not show vertical scrollbar for charts in dashboard #12478

graceguo-supercat commented Jan 12, 2021 •

edited by junlincc

Loading

rusackas commented Jan 12, 2021

graceguo-supercat commented Jan 12, 2021

rusackas commented Jan 12, 2021

codecov-io commented Jan 12, 2021 •

edited by codecov bot

Loading

ktmud commented Jan 12, 2021

rusackas commented Jan 12, 2021

ktmud commented Jan 12, 2021 •

edited

Loading

ktmud commented Jan 12, 2021

rusackas left a comment

fix: do not show vertical scrollbar for charts in dashboard #12478

fix: do not show vertical scrollbar for charts in dashboard #12478

Conversation

graceguo-supercat commented Jan 12, 2021 • edited by junlincc Loading

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

rusackas commented Jan 12, 2021

graceguo-supercat commented Jan 12, 2021

rusackas commented Jan 12, 2021

codecov-io commented Jan 12, 2021 • edited by codecov bot Loading

Codecov Report

ktmud commented Jan 12, 2021

rusackas commented Jan 12, 2021

ktmud commented Jan 12, 2021 • edited Loading

ktmud commented Jan 12, 2021

rusackas left a comment

Choose a reason for hiding this comment

graceguo-supercat commented Jan 12, 2021 •

edited by junlincc

Loading

codecov-io commented Jan 12, 2021 •

edited by codecov bot

Loading

ktmud commented Jan 12, 2021 •

edited

Loading