fix: impose dataset ownership check on old API

[dpgaspar]

SUMMARY

The old API does not check for ownership, this PR fixes it

When a user tries to changes a dataset they do not own (and their not admins):

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[villebro]

LGTM; we should probably add a note to UPDATING, as someone might currently be relying on being able to edit datasets that they're not owners of?

[dpgaspar]

@villebro good point, adding it

[codecov-io]

Codecov Report

Merging #12491 (e949170) into master (7aba4c2) will increase coverage by 0.34%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master   #12491      +/-   ##
==========================================
+ Coverage   66.29%   66.64%   +0.34%     
==========================================
  Files        1015     1015              
  Lines       49554    49582      +28     
  Branches     5079     5079              
==========================================
+ Hits        32854    33046     +192     
+ Misses      16562    16406     -156     
+ Partials      138      130       -8     

Flag	Coverage Δ
cypress	50.99% <ø> (+3.89%)	⬆️
javascript	60.76% <ø> (-0.01%)	⬇️
python	63.79% <50.00%> (-0.30%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/views/datasource.py	89.39% <42.85%> (-5.61%)	⬇️
superset/connectors/sqla/views.py	68.36% <50.00%> (-0.21%)	⬇️
superset/commands/exceptions.py	91.30% <100.00%> (ø)
superset/db_engines/hive.py	0.00% <0.00%> (-85.72%)	⬇️
superset/db_engine_specs/hive.py	54.61% <0.00%> (-29.24%)	⬇️
superset/databases/schemas.py	99.45% <0.00%> (-0.55%)	⬇️
superset/models/core.py	88.58% <0.00%> (-0.28%)	⬇️
...c/dashboard/components/nativeFilters/FilterBar.tsx	53.52% <0.00%> (+0.70%)	⬆️
superset/db_engine_specs/postgres.py	86.84% <0.00%> (+0.87%)	⬆️
...rset-frontend/src/explore/components/SaveModal.tsx	91.76% <0.00%> (+1.17%)	⬆️
... and 42 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aba4c2...bc1cac1. Read the comment docs.

[adam-stasiak]

Could you add this popup and prevent edition also for legacy editor?

legacy.mov

[villebro]

It would be nice if we could disable the buttons that the user does not have access to, like edit and delete (not necessarily here, but in a follow-up PR)

[adam-stasiak]

after latest commit:
for legacy editor: You don't have the rights to alter [FCC 2018 Survey2]
small question -> should we in [] display original name or the one we would like to set?

[dpgaspar]

@adam-stasiak unfortunately it's sort of hard to get the old state at this point just by using FAB's pre FAB hook. These views are going to be removed I hope pretty soon, so probably not worth to invest too much time on it

[serenajiang]

A lot of our users rely on editing datasets they're not owners of, so this was a breaking change. I've had to manually alter the owners of ~10 important datasets that were owned by users who are no longer active, and we're concerned that this feature might inadvertently encourage users to create duplicate datasets to avoid this restriction.

It'd be nice if we could enable this feature again with a permission (instead of a role), feature flag, or similar.

@villebro @dpgaspar