-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(native-filters): refactor filter bar #13723
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13723 +/- ##
==========================================
- Coverage 77.39% 73.23% -4.16%
==========================================
Files 928 620 -308
Lines 47024 21943 -25081
Branches 5812 5818 +6
==========================================
- Hits 36393 16070 -20323
+ Misses 10488 5730 -4758
Partials 143 143
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, assuming the the large added/removed files were functionally mostly unchanged.
* fix: fix removeing native filter * fix: fix native-cross filters * fix: fix native-cross filters * fix: fix native-cross filters * fix: fix function declaration * refactor: before pull * refactor: refactor filter bar * chore: add lic * lint: fix lint
SUMMARY
This PR refactor FilterBar code and files
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION