Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] No left padding in dashboard #13863

Closed
graceguo-supercat opened this issue Mar 30, 2021 · 3 comments · Fixed by #13905
Closed

[dashboard] No left padding in dashboard #13863

graceguo-supercat opened this issue Mar 30, 2021 · 3 comments · Fixed by #13905
Labels
#bug:regression Bugs that are identified as regessions #bug Bug report

Comments

@graceguo-supercat
Copy link

graceguo-supercat commented Mar 30, 2021 •
edited
Loading

Screenshots

  • There is no left padding in dashboard, so the content is not center aligned.
  • Open in edit mode, there is no controls to drag the whole row:

Screen Shot 2021-03-29 at 6 37 49 PM

Screen Shot 2021-03-29 at 6 38 18 PM

How to reproduce the bug

  1. Go to any dashboard
  2. Edit dashboard

Environment

latest master

cc @junlincc
@graceguo-supercat graceguo-supercat added #bug Bug report #bug:regression Bugs that are identified as regessions labels Mar 30, 2021
@junlincc
Copy link
Member

junlincc commented Mar 30, 2021 •
edited
Loading

this is bad... will push a fix asap @graceguo-supercat

@junlincc
Copy link
Member

#13723
looked at relevant changes in last few days, probably this is the one? @villebro lmk~

rusackas added a commit to preset-io/superset that referenced this issue Mar 31, 2021
@rusackas
Fixing condition around left margin for dashboard layout. Fixes apach…
4da64ce 
…e#13863
rusackas added a commit that referenced this issue Mar 31, 2021
@rusackas
fix: Consistent left margin for dashboard layout. Fixes #13863
5a049d7
@rusackas rusackas mentioned this issue Mar 31, 2021
Merged
8 tasks
@rusackas
Copy link
Member

PR open - #13884

rusackas added a commit that referenced this issue Mar 31, 2021
@rusackas
Fixing condition around left margin for dashboard layout. Fixes #13863 (
567df1f 
#13884)
@rusackas rusackas mentioned this issue Apr 1, 2021
Merged
8 tasks
etr2460 pushed a commit that referenced this issue Apr 1, 2021
@rusackas
Fixing condition around left margin for dashboard layout. Fixes #13863 (
a7f48c6 
#13905)
etr2460 pushed a commit to airbnb/superset-fork that referenced this issue Apr 1, 2021
@rusackas
Fixing condition around left margin for dashboard layout. Fixes apach…
ad2242e 
…e#13863 (apache#13905)
amitmiran137 pushed a commit that referenced this issue Apr 2, 2021
Merge branch 'master' into feat/dashboard_extra_jwt
308c659 
* master: (26 commits)
  chore: bump to new superset-ui version (#13932)
  fix: do not run containers as root by default in Helm chart (#13917)
  feat(explore): adhoc column formatting for Table chart (#13758)
  fix(sqla-query): order by aggregations in Presto and Hive (#13739)
  feat(alert/report): add ALERTS_ATTACH_REPORTS feature flags + feature (#13894)
  test: Fixes PropertiesModal_spec (#13548)
  fix: Pin Prophet dependency after breaking changes (#13852)
  test: Adds tests to dnd controls (#13650)
  test: Adds tests to the AnnotationLayer component (#13748)
  test: Refactor and enhance tests for the Explore DatasourcePanel Component (#13799)
  Add tests (#13778)
  test: DisplayQueryButton (#13750)
  Fixing condition around left margin for dashboard layout. Fixes #13863 (#13905)
  Revert "fix: select table overlay (#13694)" (#13901)
  test: Adds tests to the OptionControls component (#13729)
  test: DatasourceControl (#13605)
  tests for function handleScroll (#13896)
  test: Adds tests to the CustomFrame component (#13675)
  test: Adds tests to the AdvancedFrame component (#13664)
  test: DataTableControl (#13668)
  ...
lyndsiWilliams pushed a commit to preset-io/superset that referenced this issue Apr 7, 2021
@rusackas @lyndsiWilliams
Fixing condition around left margin for dashboard layout. Fixes apach…
b0ba3e3 
…e#13863 (apache#13905)
rusackas added a commit that referenced this issue Apr 7, 2021
@rusackas
Fixing condition around left margin for dashboard layout. Fixes #13863 (
94beb3f 
#13884)
henryyeh pushed a commit to preset-io/superset that referenced this issue Apr 9, 2021
@rusackas @henryyeh
Fixing condition around left margin for dashboard layout. Fixes apach…
ebe56a1 
…e#13863 (apache#13905)

(cherry picked from commit a7f48c6)
allanco91 pushed a commit to allanco91/superset that referenced this issue May 21, 2021
@rusackas
Fixing condition around left margin for dashboard layout. Fixes apach…
df4b108 
…e#13863 (apache#13905)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
#bug:regression Bugs that are identified as regessions #bug Bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: consistent left margin for dashboard layout. preset-io/superset
3 participants
@rusackas @graceguo-supercat @junlincc