test: DataTableControl #13668
Merged
test: DataTableControl #13668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13668 +/- ##
==========================================
- Coverage 76.46% 73.09% -3.38%
==========================================
Files 921 611 -310
Lines 46769 21755 -25014
Branches 5644 5665 +21
==========================================
- Hits 35761 15901 -19860
+ Misses 10848 5718 -5130
+ Partials 160 136 -24
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
superset-frontend/src/explore/components/DataTableControl/RowCount.test.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/explore/components/DataTableControl/RowCount.test.tsx
Outdated
Show resolved
Hide resolved
…ount.test.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
…ount.test.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
michael-s-molina
approved these changes
Mar 18, 2021
geido
approved these changes
Mar 22, 2021
| test('Render a button', () => { | ||
| render(<CopyButton>btn</CopyButton>); | ||
| expect(screen.getByRole('button')).toBeInTheDocument(); | ||
| expect(screen.getByRole('button')).toHaveClass('superset-button'); |
There was a problem hiding this comment.
Just out of curiosity, why do you think checking the class here would benefit the tests?
There was a problem hiding this comment.
It doesn't really add much value. It’s just because a test that just checks that it’s a button doesn’t add much... At least with the class I check if "added the correct button"
|
@rusackas please take a look here! |
amitmiran137
pushed a commit
that referenced
this pull request
Apr 2, 2021
* master: (26 commits) chore: bump to new superset-ui version (#13932) fix: do not run containers as root by default in Helm chart (#13917) feat(explore): adhoc column formatting for Table chart (#13758) fix(sqla-query): order by aggregations in Presto and Hive (#13739) feat(alert/report): add ALERTS_ATTACH_REPORTS feature flags + feature (#13894) test: Fixes PropertiesModal_spec (#13548) fix: Pin Prophet dependency after breaking changes (#13852) test: Adds tests to dnd controls (#13650) test: Adds tests to the AnnotationLayer component (#13748) test: Refactor and enhance tests for the Explore DatasourcePanel Component (#13799) Add tests (#13778) test: DisplayQueryButton (#13750) Fixing condition around left margin for dashboard layout. Fixes #13863 (#13905) Revert "fix: select table overlay (#13694)" (#13901) test: Adds tests to the OptionControls component (#13729) test: DatasourceControl (#13605) tests for function handleScroll (#13896) test: Adds tests to the CustomFrame component (#13675) test: Adds tests to the AdvancedFrame component (#13664) test: DataTableControl (#13668) ...
lyndsiWilliams
pushed a commit
to preset-io/superset
that referenced
this pull request
Apr 7, 2021
* Tests for DataTableControl * Update superset-frontend/src/explore/components/DataTableControl/RowCount.test.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * Update superset-frontend/src/explore/components/DataTableControl/RowCount.test.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
allanco91
pushed a commit
to allanco91/superset
that referenced
this pull request
May 21, 2021
* Tests for DataTableControl * Update superset-frontend/src/explore/components/DataTableControl/RowCount.test.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * Update superset-frontend/src/explore/components/DataTableControl/RowCount.test.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Tests for DataTableControl file
TEST PLAN
No behavior changes. All tests must pass.