Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: handleScroll #13896

Merged
merged 1 commit into from
Apr 1, 2021
Merged

test: handleScroll #13896

merged 1 commit into from
Apr 1, 2021

Conversation

yardz
Copy link
Contributor

@yardz yardz commented Mar 31, 2021

SUMMARY

Tests for function handleScroll

@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #13896 (c6605b1) into master (d54cc6d) will decrease coverage by 0.00%.
The diff coverage is 42.85%.

❗ Current head c6605b1 differs from pull request most recent head 9beb9de. Consider uploading reports for the commit 9beb9de to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13896      +/-   ##
==========================================
- Coverage   77.55%   77.54%   -0.01%     
==========================================
  Files         935      935              
  Lines       47301    47319      +18     
  Branches     5907     5907              
==========================================
+ Hits        36685    36695      +10     
- Misses      10472    10480       +8     
  Partials      144      144              
Flag Coverage Δ
cypress 56.03% <ø> (+0.01%) ⬆️
javascript 63.75% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/dashboard/components/dnd/handleScroll/index.ts 73.33% <ø> (ø)
superset/viz.py 55.90% <25.00%> (-0.17%) ⬇️
superset/examples/big_data.py 35.00% <40.00%> (+1.66%) ⬆️
superset/tasks/async_queries.py 91.07% <62.50%> (-4.93%) ⬇️
superset/db_engine_specs/presto.py 88.28% <0.00%> (-0.42%) ⬇️
superset-frontend/src/filters/utils.ts 100.00% <0.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d54cc6d...9beb9de. Read the comment docs.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit 9fd297f into apache:master Apr 1, 2021
amitmiran137 pushed a commit that referenced this pull request Apr 2, 2021
* master: (26 commits)
  chore: bump to new superset-ui version (#13932)
  fix: do not run containers as root by default in Helm chart (#13917)
  feat(explore): adhoc column formatting for Table chart (#13758)
  fix(sqla-query): order by aggregations in Presto and Hive (#13739)
  feat(alert/report): add ALERTS_ATTACH_REPORTS feature flags + feature (#13894)
  test: Fixes PropertiesModal_spec (#13548)
  fix: Pin Prophet dependency after breaking changes (#13852)
  test: Adds tests to dnd controls (#13650)
  test: Adds tests to the AnnotationLayer component (#13748)
  test: Refactor and enhance tests for the Explore DatasourcePanel Component (#13799)
  Add tests (#13778)
  test: DisplayQueryButton (#13750)
  Fixing condition around left margin for dashboard layout. Fixes #13863 (#13905)
  Revert "fix: select table overlay (#13694)" (#13901)
  test: Adds tests to the OptionControls component (#13729)
  test: DatasourceControl (#13605)
  tests for function handleScroll (#13896)
  test: Adds tests to the CustomFrame component (#13675)
  test: Adds tests to the AdvancedFrame component (#13664)
  test: DataTableControl (#13668)
  ...
lyndsiWilliams pushed a commit to preset-io/superset that referenced this pull request Apr 7, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels test:component 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants