Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: select table overlay #13694

Merged
merged 3 commits into from
Mar 26, 2021
Merged

fix: select table overlay #13694

merged 3 commits into from
Mar 26, 2021

Conversation

AAfghahi
Copy link
Member

SUMMARY

The table selector was being renderended underneath the footer and the modal background. This fixes that by giving the menu a fixed position.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before:
image

after:
Screen Shot 2021-03-18 at 3 53 26 PM

TEST PLAN

ADDITIONAL INFORMATION

@junlincc
Copy link
Member

/testenv up

@junlincc junlincc self-requested a review March 18, 2021 23:39
@junlincc junlincc added the explore:dataset Related to the dataset of Explore label Mar 18, 2021
junlincc
junlincc reviewed Mar 18, 2021
View reviewed changes
Copy link
Member

@junlincc junlincc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix, looks like the first dropdown border is still overlaid.

Let's do throughout local testing, and make sure 1) related areas are being fixed as well for consistency 2) no regression. 🙏

cc@eschutho
Screen Shot 2021-03-18 at 4 43 26 PM

Screen Shot 2021-03-18 at 4 41 44 PM

@github-actions
Copy link
Contributor

@junlincc Ephemeral environment spinning up at http://34.221.153.20:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@AAfghahi
Copy link
Member Author

Thank you for the fix, looks like the first dropdown border is still overlaid.

@junlincc so only the first dropdown isn't working? Does the second one? Sorry for not checking this, the original ticket was only for the last dropdown. My fault, thank you for finding it!

@codecov
Copy link

codecov bot commented Mar 22, 2021 •
edited
Loading

Codecov Report

Merging #13694 (927e16d) into master (64f967c) will decrease coverage by 0.12%.
The diff coverage is n/a.

❗ Current head 927e16d differs from pull request most recent head 27d6b13. Consider uploading reports for the commit 27d6b13 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13694      +/-   ##
==========================================
- Coverage   77.45%   77.32%   -0.13%     
==========================================
  Files         934      934              
  Lines       47249    47249              
  Branches     5892     5892              
==========================================
- Hits        36595    36534      -61     
- Misses      10508    10571      +63     
+ Partials      146      144       -2
Flag Coverage Δ
cypress 56.04% <ø> (+0.13%) ⬆️
hive ?
javascript 63.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/components/DatabaseSelector/index.tsx 91.66% <ø> (ø)
...et-frontend/src/components/TableSelector/index.tsx 84.92% <ø> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 74.23% <0.00%> (-16.54%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/db_engine_specs/presto.py 81.79% <0.00%> (-1.05%) ⬇️
superset/db_engine_specs/base.py 86.65% <0.00%> (-0.46%) ⬇️
...e/components/controls/FilterControl/AdhocFilter.js 96.92% <0.00%> (+3.07%) ⬆️
...t-frontend/src/dashboard/actions/dashboardState.js 68.87% <0.00%> (+5.29%) ⬆️
...rontend/src/views/CRUD/dashboard/DashboardCard.tsx 82.05% <0.00%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64f967c...27d6b13. Read the comment docs.

@AAfghahi
Copy link
Member Author

@junlincc added a couple of datasets, and this current iteration is working the way you want it.

Screen Shot 2021-03-23 at 2 24 31 PM

@AAfghahi AAfghahi force-pushed the datasetTableSelector branch from 3094398 to 27d6b13 Compare March 26, 2021 14:07
@hughhhh hughhhh merged commit b247279 into apache:master Mar 26, 2021
@hughhhh hughhhh deleted the datasetTableSelector branch March 26, 2021 14:39
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@rusackas rusackas restored the datasetTableSelector branch March 29, 2021 20:08
@junlincc junlincc mentioned this pull request Mar 29, 2021
Merged
6 tasks
@eschutho eschutho deleted the datasetTableSelector branch March 30, 2021 20:59
@eschutho eschutho restored the datasetTableSelector branch March 30, 2021 20:59
etr2460 pushed a commit to airbnb/superset-fork that referenced this pull request Mar 31, 2021
Revert "fix: select table overlay (apache#13694)"
aef08b8 
This reverts commit b247279.
@etr2460 etr2460 mentioned this pull request Apr 1, 2021
Merged
6 tasks
etr2460 pushed a commit that referenced this pull request Apr 1, 2021
Revert "fix: select table overlay (#13694)"
6ad28ef 
This reverts commit b247279.
@etr2460 etr2460 mentioned this pull request Apr 1, 2021
Merged
etr2460 pushed a commit that referenced this pull request Apr 1, 2021
Revert "fix: select table overlay (#13694)" (#13901)
5315d2c 
This reverts commit b247279.
amitmiran137 pushed a commit that referenced this pull request Apr 2, 2021
Merge branch 'master' into feat/dashboard_extra_jwt
308c659 
* master: (26 commits)
  chore: bump to new superset-ui version (#13932)
  fix: do not run containers as root by default in Helm chart (#13917)
  feat(explore): adhoc column formatting for Table chart (#13758)
  fix(sqla-query): order by aggregations in Presto and Hive (#13739)
  feat(alert/report): add ALERTS_ATTACH_REPORTS feature flags + feature (#13894)
  test: Fixes PropertiesModal_spec (#13548)
  fix: Pin Prophet dependency after breaking changes (#13852)
  test: Adds tests to dnd controls (#13650)
  test: Adds tests to the AnnotationLayer component (#13748)
  test: Refactor and enhance tests for the Explore DatasourcePanel Component (#13799)
  Add tests (#13778)
  test: DisplayQueryButton (#13750)
  Fixing condition around left margin for dashboard layout. Fixes #13863 (#13905)
  Revert "fix: select table overlay (#13694)" (#13901)
  test: Adds tests to the OptionControls component (#13729)
  test: DatasourceControl (#13605)
  tests for function handleScroll (#13896)
  test: Adds tests to the CustomFrame component (#13675)
  test: Adds tests to the AdvancedFrame component (#13664)
  test: DataTableControl (#13668)
  ...
henryyeh pushed a commit to preset-io/superset that referenced this pull request Apr 6, 2021
@henryyeh
Revert "fix: select table overlay (apache#13694)" (apache#13901)
258923e 
This reverts commit b247279.

(cherry picked from commit 5315d2c)
lyndsiWilliams pushed a commit to preset-io/superset that referenced this pull request Apr 7, 2021
@lyndsiWilliams
Revert "fix: select table overlay (apache#13694)" (apache#13901)
77823b0 
This reverts commit b247279.
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@AAfghahi
fix: select table overlay (apache#13694)
2acf664
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
Revert "fix: select table overlay (apache#13694)" (apache#13901)
014b7a2 
This reverts commit b247279.
@eschutho eschutho deleted the datasetTableSelector branch July 19, 2021 18:55
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junlincc junlincc junlincc left review comments

@hughhhh hughhhh hughhhh approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels explore:dataset Related to the dataset of Explore preset-io size/XS 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AAfghahi @junlincc @hughhhh @mistercrunch